Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Unified Diff: content/public/browser/devtools_http_handler.h

Issue 10386048: Decouple DevTools from socket implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/debugger/devtools_http_handler_impl.cc ('k') | content/shell/shell_devtools_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_http_handler.h
diff --git a/content/public/browser/devtools_http_handler.h b/content/public/browser/devtools_http_handler.h
index db0a9983001de390194bb7ba994d72c6be16d0bb..5d192819eecbd5bb3c5b68605192218bb96b06bf 100644
--- a/content/public/browser/devtools_http_handler.h
+++ b/content/public/browser/devtools_http_handler.h
@@ -11,6 +11,7 @@
#include "content/common/content_export.h"
namespace net {
+class StreamListenSocketFactory;
class URLRequestContextGetter;
}
@@ -41,10 +42,9 @@ class DevToolsHttpHandler {
CONTENT_EXPORT static int GetFrontendResourceId(
const std::string& name);
- // Takes ownership over |delegate|.
+ // Takes ownership over |socket_factory| and |delegate|.
CONTENT_EXPORT static DevToolsHttpHandler* Start(
- const std::string& ip,
- int port,
+ const net::StreamListenSocketFactory* socket_factory,
const std::string& frontend_url,
net::URLRequestContextGetter* request_context_getter,
DevToolsHttpHandlerDelegate* delegate);
« no previous file with comments | « content/browser/debugger/devtools_http_handler_impl.cc ('k') | content/shell/shell_devtools_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698