Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: chrome/browser/debugger/remote_debugging_server.cc

Issue 10386048: Decouple DevTools from socket implementation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/debugger/devtools_http_handler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/debugger/remote_debugging_server.cc
diff --git a/chrome/browser/debugger/remote_debugging_server.cc b/chrome/browser/debugger/remote_debugging_server.cc
index 0094e7e38e10f5d9a66f3a20c36c84dd161cab5f..6f378be15e469f212b36c7f13b6cf26ad289b551 100644
--- a/chrome/browser/debugger/remote_debugging_server.cc
+++ b/chrome/browser/debugger/remote_debugging_server.cc
@@ -9,6 +9,7 @@
#include "chrome/browser/ui/webui/chrome_url_data_manager.h"
#include "chrome/browser/ui/webui/devtools_ui.h"
#include "content/public/browser/devtools_http_handler.h"
+#include "net/base/tcp_listen_socket.h"
RemoteDebuggingServer::RemoteDebuggingServer(Profile* profile,
const std::string& ip,
@@ -19,12 +20,12 @@ RemoteDebuggingServer::RemoteDebuggingServer(Profile* profile,
net::URLRequestContextGetter* request_context_getter =
profile->GetRequestContext();
- devtools_http_handler_ =
- content::DevToolsHttpHandler::Start(ip,
- port,
- frontend_url,
- request_context_getter,
- new BrowserListTabContentsProvider());
+
+ devtools_http_handler_ = content::DevToolsHttpHandler::Start(
+ new net::TCPListenSocketFactory(ip, port),
+ frontend_url,
+ request_context_getter,
+ new BrowserListTabContentsProvider());
}
RemoteDebuggingServer::~RemoteDebuggingServer() {
« no previous file with comments | « no previous file | content/browser/debugger/devtools_http_handler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698