Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1155)

Unified Diff: chrome/test/automation/javascript_execution_controller.h

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/javascript_execution_controller.h
diff --git a/chrome/test/automation/javascript_execution_controller.h b/chrome/test/automation/javascript_execution_controller.h
index 7f2679b194254cf7a11255aaa0860056fba70058..8332285637772af0b432ce3f2db371d0d0a98d5a 100644
--- a/chrome/test/automation/javascript_execution_controller.h
+++ b/chrome/test/automation/javascript_execution_controller.h
@@ -23,7 +23,6 @@ class JavaScriptExecutionController
: public base::SupportsWeakPtr<JavaScriptExecutionController> {
public:
JavaScriptExecutionController();
- virtual ~JavaScriptExecutionController();
// Executes |script| and parse the return value. Returns whether the
// execution and parsing succeeded.
@@ -76,6 +75,8 @@ class JavaScriptExecutionController
static void set_timeout(int timeout_ms) { timeout_ms_ = timeout_ms; }
protected:
+ virtual ~JavaScriptExecutionController();
+
// Executes |script| and sets the JSON response |json|. Returns true
// on success.
virtual bool ExecuteJavaScriptAndGetJSON(const std::string& script,
« no previous file with comments | « chrome/service/cloud_print/print_system.h ('k') | chrome/test/automation/javascript_execution_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698