RefCounted types should not have public destructors, delegate cleanup

chrome/test/automation/javascript_execution_controller.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_TEST_AUTOMATION_JAVASCRIPT_EXECUTION_CONTROLLER_H_
 #define CHROME_TEST_AUTOMATION_JAVASCRIPT_EXECUTION_CONTROLLER_H_
 #pragma once
 
 #include <map>
 #include <string>
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/values.h"
 #include "chrome/test/automation/javascript_message_utils.h"
 
 class JavaScriptObjectProxy;
 
 // This class handles the execution of arbitrary JavaScript, preparing it for
 // execution, and parsing its result (in JSON). It keeps track of all returned
 // JavaScript objects.
 class JavaScriptExecutionController
     : public base::SupportsWeakPtr<JavaScriptExecutionController> {
  public:
   JavaScriptExecutionController();
-  virtual ~JavaScriptExecutionController();
 
   // Executes |script| and parse the return value. Returns whether the
   // execution and parsing succeeded.
   template <typename T>
   bool ExecuteJavaScriptAndGetReturn(const std::string& script, T* result) {
     scoped_ptr<Value> returnValue;
     if (!ExecuteAndParseHelper(WrapJavaScript(script), &returnValue))
       return false;
     return ValueConversionTraits<T>::SetFromValue(returnValue.get(), result);
   }
@@ skipping 32 matching lines @@
       obj = static_cast<JavaScriptObject*>(iter->second);
     }
     return obj;
   }
 
   // Sets a timeout to be used for all JavaScript methods in which a response
   // is returned asynchronously.
   static void set_timeout(int timeout_ms) { timeout_ms_ = timeout_ms; }
 
  protected:
+  virtual ~JavaScriptExecutionController();
+
   // Executes |script| and sets the JSON response |json|. Returns true
   // on success.
   virtual bool ExecuteJavaScriptAndGetJSON(const std::string& script,
                                            std::string* json) = 0;
 
   // Called when this controller is tracking its first object. Used by
   // reference counted subclasses.
   virtual void FirstObjectAdded() {}
 
   // Called when this controller is no longer tracking any objects. Used by
@@ skipping 24 matching lines @@
   // Timeout to use for all asynchronous methods.
   static int timeout_ms_;
 
   // Weak pointer to all the object proxies that we create.
   HandleToObjectMap handle_to_object_;
 
   DISALLOW_COPY_AND_ASSIGN(JavaScriptExecutionController);
 };
 
 #endif  // CHROME_TEST_AUTOMATION_JAVASCRIPT_EXECUTION_CONTROLLER_H_