Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7535)

Unified Diff: chrome/test/automation/javascript_execution_controller.cc

Issue 10383262: RefCounted types should not have public destructors, delegate cleanup (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make win bot happy Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/automation/javascript_execution_controller.cc
diff --git a/chrome/test/automation/javascript_execution_controller.cc b/chrome/test/automation/javascript_execution_controller.cc
index 9918bb1924a2b3286e522a97eea82e81fafd232a..cd058cf2923e0c489b866e33061bb7460f8c8080 100644
--- a/chrome/test/automation/javascript_execution_controller.cc
+++ b/chrome/test/automation/javascript_execution_controller.cc
@@ -16,8 +16,6 @@ int JavaScriptExecutionController::timeout_ms_ = -1;
JavaScriptExecutionController::JavaScriptExecutionController() {}
-JavaScriptExecutionController::~JavaScriptExecutionController() {}
-
bool JavaScriptExecutionController::ExecuteJavaScript(
const std::string& script) {
scoped_ptr<Value> return_value;
@@ -30,6 +28,8 @@ bool JavaScriptExecutionController::ExecuteAsyncJavaScript(
return ExecuteAndParseHelper(WrapAsyncJavaScript(script), &return_value);
}
+JavaScriptExecutionController::~JavaScriptExecutionController() {}
+
void JavaScriptExecutionController::Remove(int handle) {
handle_to_object_.erase(handle);
if (handle_to_object_.empty())
« no previous file with comments | « chrome/test/automation/javascript_execution_controller.h ('k') | content/browser/device_orientation/provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698