Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests

Issue 10381030: Clean up testing of instructions. Allow testing to quit if test pattern tests (Closed)

Created:
8 years, 7 months ago by Karl

Modified:
8 years, 7 months ago

Reviewers:
sehr (please use chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/native_client/trunk/src/native_client/

Visibility:
Public.

More Reviews

Description

Clean up testing of instructions. Allow testing to quit if test pattern tests something the tester knows is not part of the rule. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2673 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8518

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+306 lines, -194 lines)			Patch
M	src/trusted/validator_arm/actual_classes.h	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	src/trusted/validator_arm/actual_vs_baseline.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/trusted/validator_arm/actual_vs_baseline.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/armv7.table	View	1	4 chunks	+4 lines, -3 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/trusted/validator_arm/baseline_classes.cc	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	src/trusted/validator_arm/decoder_tester.h	View	1	2 chunks	+21 lines, -3 lines	0 comments	Download
M	src/trusted/validator_arm/decoder_tester.cc	View	1	1 chunk	+5 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode.cc	View	1	3 chunks	+30 lines, -4 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_classes.h	View	1	4 chunks	+28 lines, -28 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_named_decoder.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/trusted/validator_arm/gen/arm32_decode_tests.cc	View	1	6 chunks	+26 lines, -26 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes_testers.h	View	1	22 chunks	+22 lines, -22 lines	0 comments	Download
M	src/trusted/validator_arm/inst_classes_testers.cc	View	1	47 chunks	+138 lines, -95 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sehr (please use chromium)

8 years, 7 months ago (2012-05-07 21:07:18 UTC) #2

One comment clarification.  Fix and LGTM.

https://chromiumcodereview.appspot.com/10381030/diff/1/src/trusted/validator_...
File src/trusted/validator_arm/actual_classes.h (right):

https://chromiumcodereview.appspot.com/10381030/diff/1/src/trusted/validator_...
src/trusted/validator_arm/actual_classes.h:263: // TODO(karl) Decide why we ever
allowed this.
A little more specific comment, please.  Determine why we ever allowed BIC to
directly write PC.

Expand Messages | Collapse Messages