Clean up testing of instructions. Allow testing to quit if test pattern tests

src/trusted/validator_arm/actual_classes.h

 /*
  * Copyright (c) 2012 The Native Client Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #ifndef NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_ACTUAL_CLASSES_H_
 #define NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_ACTUAL_CLASSES_H_
 
 #include "native_client/src/trusted/validator_arm/inst_classes.h"
@@ skipping 242 matching lines @@
 
 // A special-case data processing instruction: the immediate BIC.  We consider
 // this the only instruction that reliably clears bits in its result, so we
 // model it separately from other logic ops.
 class ImmediateBic : public DataProc {
  public:
   static const Imm12Bits0To11Interface imm12;
   inline ImmediateBic() {}
   virtual ~ImmediateBic() {}
 
+  // TODO(karl) Decide why we ever allowed this.

[sehr (please use chromium), 2012/05/07 21:07:18]

A little more specific comment, please.  Determine why we ever allowed BIC to
directly write PC.

   // ImmediateBic is exempted from the writes-r15 check.
-  virtual SafetyLevel safety(Instruction i) const {
-    UNREFERENCED_PARAMETER(i);
-    return MAY_BE_SAFE;
-  }
+  // virtual SafetyLevel safety(Instruction i) const {
+  //   UNREFERENCED_PARAMETER(i);
+  //   return MAY_BE_SAFE;
+  // }
   virtual bool clears_bits(Instruction i, uint32_t mask) const;
 
  private:
   NACL_DISALLOW_COPY_AND_ASSIGN(ImmediateBic);
 };
 
 // Models the Pack/Saturate/Reverse instructions, which
 //  - Write a register identified by 15:12,
 //  - Are not permitted to affect r15,
 //  - Always set flags.
@@ skipping 618 matching lines @@
   }
   virtual int32_t branch_target_offset(Instruction i) const;
 
  private:
   NACL_DISALLOW_COPY_AND_ASSIGN(Branch);
 };
 
 }  // namespace
 
 #endif  // NATIVE_CLIENT_SRC_TRUSTED_VALIDATOR_ARM_ACTUAL_CLASSES_H_