ash: First pass of Applist v2.

ash: First pass of Applist v2.

- Add an "enable-applist-v2" command line switch and an about flag to trigger v2;
- Add paging support to AppListModelView;
- Add page switcher buttons for v2 UI;
- Add AppListBubbleBorder to paint bubble for v2 UI;

BUG=125964, 125044
TEST=Issue 125964 is not ready for test yet. For issue 125044, user can now gets overflown apps via keyboard.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135729

[tfarina, 2012-05-04 22:39:19]

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h
File ash/app_list/app_list_view.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h#n...
ash/app_list/app_list_view.h:60: // OVerridden from views::BubbleDelegate:
nit: Overridden

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h#n...
ash/app_list/app_list_view.h:70: AppListBubbleBorder* bubble_border_;
just curious, who owns this?

http://codereview.chromium.org/10381018/diff/1/ash/app_list/pagination_model.h
File ash/app_list/pagination_model.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/app_list/pagination_model....
ash/app_list/pagination_model.h:44: }  // namespace ui
nit: namespace ash

[tfarina, 2012-05-04 22:41:55]

http://codereview.chromium.org/10381018/diff/1/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/launcher/launcher.h#newcode12
ash/launcher/launcher.h:12: #include "ash/ash_export.h"
nit: sort

[xiyuan, 2012-05-04 23:00:28]

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h
File ash/app_list/app_list_view.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h#n...
ash/app_list/app_list_view.h:60: // OVerridden from views::BubbleDelegate:
On 2012/05/04 22:39:19, tfarina wrote:
> nit: Overridden

Done.

http://codereview.chromium.org/10381018/diff/1/ash/app_list/app_list_view.h#n...
ash/app_list/app_list_view.h:70: AppListBubbleBorder* bubble_border_;
On 2012/05/04 22:39:19, tfarina wrote:
> just curious, who owns this?

views hierarchy owns it. Comment added.

http://codereview.chromium.org/10381018/diff/1/ash/app_list/pagination_model.h
File ash/app_list/pagination_model.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/app_list/pagination_model....
ash/app_list/pagination_model.h:44: }  // namespace ui
On 2012/05/04 22:39:19, tfarina wrote:
> nit: namespace ash

Done.

http://codereview.chromium.org/10381018/diff/1/ash/launcher/launcher.h
File ash/launcher/launcher.h (right):

http://codereview.chromium.org/10381018/diff/1/ash/launcher/launcher.h#newcode12
ash/launcher/launcher.h:12: #include "ash/ash_export.h"
On 2012/05/04 22:41:55, tfarina wrote:
> nit: sort

Done.

[sky, 2012-05-06 22:51:15]

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view.cc
File ash/app_list/app_list_view.cc (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view....
ash/app_list/app_list_view.cc:41: const int kModelViewFooterPadding = 10;
nit: this last one isn't that obvious, add a description.

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view....
ash/app_list/app_list_view.cc:162:
set_anchor_view(Shell::GetInstance()->launcher()->GetAppListButtonView());
Is the launcher always visible when we do this?

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/page_switcher.h
File ash/app_list/page_switcher.h (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/page_switcher....
ash/app_list/page_switcher.h:18: class PageSwitcher : public views::View,
add a description.

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/pagination_mod...
File ash/app_list/pagination_model.h (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/pagination_mod...
ash/app_list/pagination_model.h:17: class ASH_EXPORT PaginationModel {
Description.

[xiyuan, 2012-05-07 16:46:10]

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view.cc
File ash/app_list/app_list_view.cc (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view....
ash/app_list/app_list_view.cc:41: const int kModelViewFooterPadding = 10;
On 2012/05/06 22:51:15, sky wrote:
> nit: this last one isn't that obvious, add a description.

Done.

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/app_list_view....
ash/app_list/app_list_view.cc:162:
set_anchor_view(Shell::GetInstance()->launcher()->GetAppListButtonView());
On 2012/05/06 22:51:15, sky wrote:
> Is the launcher always visible when we do this?

Yes, launcher will always be visible. In
ShelfLayoutManager::CalculateAutoHideState, we put shelf in AUTO_HIDE_SHOWN when
auto hide is on.

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/page_switcher.h
File ash/app_list/page_switcher.h (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/page_switcher....
ash/app_list/page_switcher.h:18: class PageSwitcher : public views::View,
On 2012/05/06 22:51:15, sky wrote:
> add a description.

Done.

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/pagination_mod...
File ash/app_list/pagination_model.h (right):

http://codereview.chromium.org/10381018/diff/5001/ash/app_list/pagination_mod...
ash/app_list/pagination_model.h:17: class ASH_EXPORT PaginationModel {
On 2012/05/06 22:51:15, sky wrote:
> Description.

Done.

[sky, 2012-05-07 17:03:27]

LGTM

[commit-bot: I haz the power, 2012-05-07 19:31:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10381018/4002

[commit-bot: I haz the power, 2012-05-07 19:31:42]

Can't apply patch for file ash/app_list/app_list.cc.
While running patch -p1 --forward --force;
patching file ash/app_list/app_list.cc
Hunk #1 FAILED at 6.
1 out of 7 hunks FAILED -- saving rejects to file ash/app_list/app_list.cc.rej

[commit-bot: I haz the power, 2012-05-07 19:44:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10381018/12002

[commit-bot: I haz the power, 2012-05-07 21:34:37]

Try job failure for 10381018-12002 (retry) on win_rel for step "update".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.