Move Extension into extensions namespace

Move Extension into extensions namespace

BUG=117262
TBR=aa@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138074

[Aaron Boodman, 2012-05-11 22:58:39]

lgtm

[commit-bot: I haz the power, 2012-05-11 23:06:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/1...

[commit-bot: I haz the power, 2012-05-11 23:09:40]

Can't apply patch for file chrome/browser/tabs/pinned_tab_codec.cc.
While running patch -p1 --forward --force;
A         chrome/browser/tabs
patching file chrome/browser/tabs/pinned_tab_codec.cc
Hunk #1 FAILED at 56.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/tabs/pinned_tab_codec.cc.rej

[commit-bot: I haz the power, 2012-05-12 18:01:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/1...

[commit-bot: I haz the power, 2012-05-12 18:04:40]

Can't apply patch for file chrome/browser/chrome_content_browser_client.cc.
While running patch -p1 --forward --force;
patching file chrome/browser/chrome_content_browser_client.cc
Hunk #1 FAILED at 153.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/chrome_content_browser_client.cc.rej

[commit-bot: I haz the power, 2012-05-14 02:15:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/7014

[commit-bot: I haz the power, 2012-05-14 02:19:08]

Presubmit check for 10375021-7014 failed and returned exit status 1.

Running presubmit commit checks ...
  checking nsobjects took a long time: 759ms
  checking eol style took a long time: 760ms

** Presubmit Messages **
You might be calling functions intended only for testing from
production code.  It is OK to ignore this warning if you know what
you are doing, as the heuristics used to detect the situation are
not perfect.  The commit queue will not block on this warning.
Email joi@chromium.org if you have questions.
  chrome/common/extensions/feature.cc:363
    g_channel.Get().SetChannelForTesting(channel); \
  chrome/common/extensions/feature.cc:368
    g_channel.Get().ResetChannelForTesting();

If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/ui/tabs
    chrome/browser/ui/cocoa/infobars
    chrome/browser/sessions
    chrome/browser/ui/intents
    chrome/browser/ui/gtk
    chrome/browser/ui/views/ash/launcher
    chrome/browser/ui/webui/options2
    chrome/browser/sync
    chrome/browser/component_updater
    chrome/browser/bookmarks
    chrome/browser/ui/webui/ntp
    chrome/browser/ui/webui
    chrome/browser/search_engines
    chrome/browser/history
    chrome/browser/profiles
    chrome/browser/ui/cocoa/location_bar
    chrome/browser/ui
    chrome/browser/ui/cocoa
    chrome/browser/ui/views/ash/app_list
    chrome/browser/ui/panels
    chrome/browser/policy

Add a description.

Presubmit checks took 27.0s to calculate.

[mitchellwrosen, 2012-05-14 02:45:45]

+sky for browser/ui, browser/sessions/ browser/bookmarks, browser/history
+akalin for browser/sync
+asargent for browser/component_updater
+mirandac for browser/profiles
+mnissler for browser/policy

[Mattias Nissler (ping if slow), 2012-05-14 08:09:31]

chrome/browser/policy LGTM

[sky, 2012-05-14 15:00:06]

LGTM - I would have TBRd this.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_application_list_model.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_application_list_model.cc:38: bool
operator()(const Extension* x,
Leave this the way it was.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_application_list_model.h (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_application_list_model.h:104: const
Application* FindApplication(const extensions::Extension* extension)
don't leave const dangling.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_mode_manager.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_mode_manager.cc:313:
content::Details<UpdatedExtensionPermissionsInfo>( details).ptr();
'( d' -> '(d'

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/ui/v...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/ui/v...
chrome/browser/ui/views/frame/browser_view.cc:1109: void
BrowserView::ShowCreateChromeAppShortcutsDialog(Profile* profile,
wrap this to next line too.

[commit-bot: I haz the power, 2012-05-14 18:13:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/7014

[commit-bot: I haz the power, 2012-05-14 18:41:38]

Try job failure for 10375021-7014 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[aa, 2012-05-14 19:09:50]

On Mon, May 14, 2012 at 11:41 AM,  <commit-bot@chromium.org> wrote:
> Try job failure for 10375021-7014 (retry) on linux_chromeos for step
> "compile"
> (clobber build).
> It's a second try, previously, step "compile" failed.
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

I wasn't sure if TBR worked for non-comitters. I tried it; seems to
work. But now the patch is out of date.

Mitchell, find me when you come online and I'll help you get this landed.

- a

[commit-bot: I haz the power, 2012-05-18 22:49:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/1...

[mitchellwrosen, 2012-05-18 22:53:16]

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_application_list_model.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_application_list_model.cc:38: bool
operator()(const Extension* x,
On 2012/05/14 15:00:07, sky wrote:
> Leave this the way it was.

Done.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_application_list_model.h (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_application_list_model.h:104: const
Application* FindApplication(const extensions::Extension* extension)
On 2012/05/14 15:00:07, sky wrote:
> don't leave const dangling.

Done.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
File chrome/browser/background/background_mode_manager.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/back...
chrome/browser/background/background_mode_manager.cc:313:
content::Details<UpdatedExtensionPermissionsInfo>( details).ptr();
On 2012/05/14 15:00:07, sky wrote:
> '( d' -> '(d'

Done.

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/ui/v...
File chrome/browser/ui/views/frame/browser_view.cc (right):

https://chromiumcodereview.appspot.com/10375021/diff/7014/chrome/browser/ui/v...
chrome/browser/ui/views/frame/browser_view.cc:1109: void
BrowserView::ShowCreateChromeAppShortcutsDialog(Profile* profile,
On 2012/05/14 15:00:07, sky wrote:
> wrap this to next line too.

Done.

[commit-bot: I haz the power, 2012-05-18 23:26:58]

Try job failure for 10375021-19003 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-05-19 17:40:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/2...

[commit-bot: I haz the power, 2012-05-19 18:13:57]

Try job failure for 10375021-22001 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-05-19 18:34:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/2...

[commit-bot: I haz the power, 2012-05-19 18:36:15]

Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 500: 
<html><head>
<meta http-equiv="content-type" content="text/html;charset=utf-8">
<title>500 Server Error</title>
</head>
<body text=#000000 bgcolor=#ffffff>
<h1>Error: Server Error</h1>
<h2>The server encountered an error and could not complete your request.<p>If
the problem persists, please <A
HREF="http://code.google.com/appengine/community.html">report</A> your problem
and mention this error message and the query that caused it.</h2>
<h2></h2>
</body></html>

[commit-bot: I haz the power, 2012-05-19 18:47:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/1...

[commit-bot: I haz the power, 2012-05-19 19:13:19]

Try job failure for 10375021-12265 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[mitchellwrosen, 2012-05-19 21:30:23]

So for some reason, even after gclient sync --force, my *master* branch is seg
faulting on a few browser tests. My coworkers aren't having the same problem. I
have no idea why. I was hoping I could get this landed today (Saturday), but it
looks like it's not going to happen. Sorry, guys.

[commit-bot: I haz the power, 2012-05-19 23:02:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mitchellwrosen@chromium.org/10375021/7469

[commit-bot: I haz the power, 2012-05-20 00:08:15]

Try job failure for 10375021-7469 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[Aaron Boodman, 2012-05-21 02:36:45]

I am going to land this for you :)

[mitchellwrosen, 2012-05-21 03:15:41]

On 2012/05/21 02:36:45, Aaron Boodman wrote:
> I am going to land this for you :)

Thanks, it's a hard bug to land when I only work a few days a week, for a few
hours at a time, and the trybots take a few hours to complete.