chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc - Issue 10375021: Move Extension into extensions namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

Issue 10375021: Move Extension into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Take 6 Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_icon_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_isolatedapp_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

index 0840c8771acc5155dfa62dae9b500557676645a3..588017bd92083cecd55401d4c8b732e75244a901 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc

@@ -74,14 +74,14 @@ TEST_F(ExtensionManifestTest, InitFromValueInvalid) {

}

TEST_F(ExtensionManifestTest, InitFromValueValid) {

- scoped_refptr<Extension> extension(LoadAndExpectSuccess(

+ scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess(

"init_valid_minimal.json"));

FilePath path;

PathService::Get(chrome::DIR_TEST_DATA, &path);

path = path.AppendASCII("extensions");

- EXPECT_TRUE(Extension::IdIsValid(extension->id()));

+ EXPECT_TRUE(extensions::Extension::IdIsValid(extension->id()));

EXPECT_EQ("1.0.0.0", extension->VersionString());

EXPECT_EQ("my extension", extension->name());

EXPECT_EQ(extension->id(), extension->url().host());

@@ -134,7 +134,7 @@ TEST_F(ExtensionManifestTest, InitFromValueValidNameInRTL) {

#endif

// No strong RTL characters in name.

- scoped_refptr<Extension> extension(LoadAndExpectSuccess(

+ scoped_refptr<extensions::Extension> extension(LoadAndExpectSuccess(

"init_valid_name_no_rtl.json"));

string16 localized_name(ASCIIToUTF16("Dictionary (by Google)"));