chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc - Issue 10375021: Move Extension into extensions namespace

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

Issue 10375021: Move Extension into extensions namespace (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Take 6 Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc ('k') | chrome/common/extensions/manifest_tests/extension_manifests_tts_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

diff --git a/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc b/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

index 8acb36c61fbb0774439fe7bfeae5fbc7bb27beca..e020bf05053dd19da2f2be9c4789a5a12823394c 100644

--- a/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

+++ b/chrome/common/extensions/manifest_tests/extension_manifests_storage_unittest.cc

@@ -25,7 +25,8 @@ TEST_F(ExtensionManifestTest, StorageAPIManifestVersionAvailability) {

// Extension with no manifest version cannot use storage API.

{

Manifest manifest(&base_manifest, "test");

- scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);

+ scoped_refptr<extensions::Extension> extension =

+ LoadAndExpectSuccess(manifest);

if (extension.get()) {

std::vector<std::string> warnings;

warnings.push_back(kManifestVersionError);

@@ -40,7 +41,8 @@ TEST_F(ExtensionManifestTest, StorageAPIManifestVersionAvailability) {

manifest_with_version.MergeDictionary(&base_manifest);

Manifest manifest(&manifest_with_version, "test");

- scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);

+ scoped_refptr<extensions::Extension> extension =

+ LoadAndExpectSuccess(manifest);

if (extension.get()) {

std::vector<std::string> warnings;

warnings.push_back(kManifestVersionError);

@@ -55,7 +57,8 @@ TEST_F(ExtensionManifestTest, StorageAPIManifestVersionAvailability) {

manifest_with_version.MergeDictionary(&base_manifest);

Manifest manifest(&manifest_with_version, "test");

- scoped_refptr<Extension> extension = LoadAndExpectSuccess(manifest);

+ scoped_refptr<extensions::Extension> extension =

+ LoadAndExpectSuccess(manifest);

if (extension.get()) {

std::vector<std::string> empty;

EXPECT_EQ(empty, extension->install_warnings());