Re-enable <input type="file"> for platform apps.

Re-enable <input type="file"> for platform apps.

This was broken by r136239.

BUG=None
TEST=Tested file inputs work again.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137623

[benwells, 2012-05-17 00:46:46]

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
File chrome/browser/ui/extensions/shell_window.cc (left):

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
chrome/browser/ui/extensions/shell_window.cc:155: // TODO(benwells): Rearrange
so users of this can call
Turns out some implementers of ShouldSuppressDialogs do more than return true /
false, but use it as a signal that the renderer wants to show a dialog.

[Mihai Parparita -not on Chrome, 2012-05-17 00:51:44]

LGTM

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
File chrome/browser/ui/extensions/shell_window.cc (right):

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
chrome/browser/ui/extensions/shell_window.cc:175:
Browser::RunFileChooserHelper(tab, params);
Huh, Browser seems like an odd place for this helper method.

Scott, can you think of a better place for it?

[benwells, 2012-05-17 01:02:26]

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
File chrome/browser/ui/extensions/shell_window.cc (right):

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
chrome/browser/ui/extensions/shell_window.cc:175:
Browser::RunFileChooserHelper(tab, params);
On 2012/05/17 00:51:44, Mihai Parparita wrote:
> Huh, Browser seems like an odd place for this helper method.
> 
> Scott, can you think of a better place for it?

There are a bunch of helpers like this on Browser:
EnumerateDirectoryHelper
JSOutOfMemoryHelper
....

[commit-bot: I haz the power, 2012-05-17 01:56:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/benwells@chromium.org/10332213/1

[commit-bot: I haz the power, 2012-05-17 03:18:37]

Change committed as 137623

[sky, 2012-05-17 03:57:36]

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
File chrome/browser/ui/extensions/shell_window.cc (right):

http://codereview.chromium.org/10332213/diff/1/chrome/browser/ui/extensions/s...
chrome/browser/ui/extensions/shell_window.cc:175:
Browser::RunFileChooserHelper(tab, params);
On 2012/05/17 01:02:26, benwells wrote:
> On 2012/05/17 00:51:44, Mihai Parparita wrote:
> > Huh, Browser seems like an odd place for this helper method.
> > 
> > Scott, can you think of a better place for it?
> 
> There are a bunch of helpers like this on Browser:
> EnumerateDirectoryHelper
> JSOutOfMemoryHelper
> ....

How about a static method on FileSelectHelper? And just because there are a
bunch of random unrelated methods on Browser doesn't mean we should add more.
Browser sorely needs some love.

[Mihai Parparita -not on Chrome, 2012-05-22 00:21:29]

On Wed, May 16, 2012 at 8:57 PM, <sky@chromium.org> wrote:

> How about a static method on FileSelectHelper?


Sent out https://chromiumcodereview.appspot.com/10411064 to do this

Mihai