Re-enable <input type="file"> for platform apps.

chrome/browser/ui/extensions/shell_window.cc

Index: chrome/browser/ui/extensions/shell_window.cc
diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc
index be97abdc24086bab77fd8fcf9cd88b176e987516..0e19687a3ea8b01d0d30ca24fc203da3be74ea71 100644
--- a/chrome/browser/ui/extensions/shell_window.cc
+++ b/chrome/browser/ui/extensions/shell_window.cc
@@ -12,6 +12,7 @@
 #include "chrome/browser/intents/web_intents_util.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/sessions/session_id.h"
+#include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/intents/web_intent_picker_controller.h"
 #include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
 #include "chrome/common/chrome_notification_types.h"
@@ -152,9 +153,6 @@ void ShellWindow::CloseContents(WebContents* contents) {
   Close();
 }
 
-// TODO(benwells): Rearrange so users of this can call

[benwells, 2012/05/17 00:46:46]

Turns out some implementers of ShouldSuppressDialogs do more than return true /
false, but use it as a signal that the renderer wants to show a dialog.

-// WebContents::set_should_suppress_dialogs(bool) instead of overriding
-// this delegate function.
 bool ShellWindow::ShouldSuppressDialogs() {
   return true;
 }
@@ -172,6 +170,11 @@ void ShellWindow::WebIntentDispatch(
       intents_dispatcher->GetIntent().type);
 }
 
+void ShellWindow::RunFileChooser(WebContents* tab,
+                                 const content::FileChooserParams& params) {
+  Browser::RunFileChooserHelper(tab, params);

[Mihai Parparita -not on Chrome, 2012/05/17 00:51:44]

Huh, Browser seems like an odd place for this helper method.

Scott, can you think of a better place for it?

[benwells, 2012/05/17 01:02:26]

There are a bunch of helpers like this on Browser:
EnumerateDirectoryHelper
JSOutOfMemoryHelper
....

[sky, 2012/05/17 03:57:37]

How about a static method on FileSelectHelper? And just because there are a
bunch of random unrelated methods on Browser doesn't mean we should add more.
Browser sorely needs some love.

+}
+
 void ShellWindow::Observe(int type,
                           const content::NotificationSource& source,
                           const content::NotificationDetails& details) {