Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10411064: Move RunFileChooserHelper and EnumerateDirectoryHelper out of Browser. (Closed)

Created:
8 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Move RunFileChooserHelper and EnumerateDirectoryHelper out of Browser. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=138296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -62 lines) Patch
M chrome/browser/extensions/extension_host.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/external_tab/external_tab_container_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/file_select_helper.h View 3 chunks +13 lines, -7 lines 0 comments Download
M chrome/browser/file_select_helper.cc View 7 chunks +33 lines, -11 lines 0 comments Download
M chrome/browser/ui/browser.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/ui/browser.cc View 2 chunks +4 lines, -31 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Mihai Parparita -not on Chrome
8 years, 7 months ago (2012-05-22 00:21:04 UTC) #1
sky
LGTM
8 years, 7 months ago (2012-05-22 00:28:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10411064/1
8 years, 7 months ago (2012-05-22 00:29:56 UTC) #3
commit-bot: I haz the power
Try job failure for 10411064-1 (retry) (retry) on win_rel for step "sync_unit_tests" (clobber build). It's ...
8 years, 7 months ago (2012-05-22 05:10:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10411064/1
8 years, 7 months ago (2012-05-22 06:06:50 UTC) #5
commit-bot: I haz the power
Try job failure for 10411064-1 (retry) on win_rel for step "sync_unit_tests". It's a second try, ...
8 years, 7 months ago (2012-05-22 09:06:29 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10411064/1
8 years, 7 months ago (2012-05-22 15:24:19 UTC) #7
commit-bot: I haz the power
Try job failure for 10411064-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 7 months ago (2012-05-22 15:48:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10411064/1
8 years, 7 months ago (2012-05-22 16:47:25 UTC) #9
commit-bot: I haz the power
8 years, 7 months ago (2012-05-22 17:59:45 UTC) #10 
Try job failure for 10411064-1 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Powered by Google App Engine
This is Rietveld 408576698