Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 10332163: Revert 137075 - Get rid of Image::Image(SkBitmap*) (Closed)

Created:
8 years, 7 months ago by pkotwicz
Modified:
8 years, 7 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, ajwong+watch_chromium.org, Aaron Boodman, pam+watch_chromium.org, brettw-cc_chromium.org, creis+watch_chromium.org
Visibility:
Public.

Description

Revert 137075 - Get rid of Image::Image(SkBitmap*) Bug=124566 Test=Compiles on CrOS,Mac Review URL: https://chromiumcodereview.appspot.com/10378009 TBR=pkotwicz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137076

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -113 lines) Patch
M ash/wm/image_grid_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_install_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon/favicon_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/expire_history_backend_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/icon_loader_chromeos.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/icon_loader_linux.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/icon_loader_win.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_theme_service.cc View 3 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/ui/intents/web_intent_picker_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/base/resource/resource_bundle.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/gfx/image/image.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gfx/image/image.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M ui/gfx/image/image_unittest.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M ui/gfx/image/image_unittest_util.h View 2 chunks +2 lines, -6 lines 0 comments Download
M ui/gfx/image/image_unittest_util.cc View 3 chunks +10 lines, -26 lines 0 comments Download
M ui/gfx/image/image_util.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
pkotwicz
8 years, 7 months ago (2012-05-15 03:57:08 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698