Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/tools/profiles/generate_profile.cc

Issue 10332163: Revert 137075 - Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | ui/base/resource/resource_bundle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/profiles/generate_profile.cc
===================================================================
--- chrome/tools/profiles/generate_profile.cc (revision 137075)
+++ chrome/tools/profiles/generate_profile.cc (working copy)
@@ -181,9 +181,9 @@
if (types & FULL_TEXT)
history_service->SetPageContents(url, ConstructRandomPage());
if (types & TOP_SITES && top_sites) {
- const SkBitmap& bitmap = (RandomInt(0, 2) == 0) ? *google_bitmap :
- *weewar_bitmap;
- gfx::Image image(bitmap);
+ SkBitmap* bitmap = (RandomInt(0, 2) == 0) ? google_bitmap.get() :
+ weewar_bitmap.get();
+ gfx::Image image(new SkBitmap(*bitmap));
top_sites->SetPageThumbnail(url, &image, score);
}
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | ui/base/resource/resource_bundle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698