Issue 10378009: Get rid of Image::Image(SkBitmap*)

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed)

Created:
8 years, 7 months ago by pkotwicz

Modified:
8 years, 7 months ago

Reviewers:
Robert Sesek, sky

CC:
chromium-reviews, Avi (use Gerrit), mihaip-chromium-reviews_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org, Aaron Boodman, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Get rid of Image::Image(SkBitmap*) Bug=124566 Test=Compiles on CrOS,Mac Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137075 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137140

Patch Set 2 : Changes as requested #

Patch Set 8 : fixes for recent reverts #

Patch Set 9 : k #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -102 lines)			Patch
M	ash/wm/image_grid_unittest.cc	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_install_ui.cc	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/favicon/favicon_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/expire_history_backend_unittest.cc	View	1 2 3 4 5	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/history/history_backend_unittest.cc	View	1 2 3	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/history/history_tab_helper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/history/top_sites_unittest.cc	View	1 2 3	1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/icon_loader_chromeos.cc	View	1 2 3 4 5 6	2 chunks	+8 lines, -8 lines	0 comments	Download
M	chrome/browser/icon_loader_linux.cc	View	1 2 3	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/icon_loader_win.cc	View	1 2 3 4 5 6 7	2 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/profiles/gaia_info_update_service.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/tab_contents/thumbnail_generator.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/extensions/extension_install_dialog_controller_unittest.mm	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.h	View	1 2 3 4 5 6	1 chunk	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_theme_service.cc	View	1 2 3 4 5 6	3 chunks	+14 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/intents/web_intent_picker_controller.cc	View	1 2 3 4 5 6	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/tools/profiles/generate_profile.cc	View	1 2 3 4 5 6 7	1 chunk	+3 lines, -3 lines	0 comments	Download
M	ui/base/resource/resource_bundle.cc	View	1 2 3 4 5 6 7	1 chunk	+4 lines, -4 lines	0 comments	Download
M	ui/gfx/image/image.h	View	7	1 chunk	+0 lines, -4 lines	0 comments	Download
M	ui/gfx/image/image.cc	View	7	1 chunk	+0 lines, -7 lines	0 comments	Download
M	ui/gfx/image/image_mac_unittest.mm	View	1 7 8	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/gfx/image/image_unittest.cc	View	1 2 3 4 5 6 7 8	8 chunks	+11 lines, -11 lines	0 comments	Download
M	ui/gfx/image/image_unittest_util.h	View	1 2 3 4 5 6	2 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/gfx/image/image_unittest_util.cc	View	1 2 3 4 5 6	3 chunks	+26 lines, -10 lines	0 comments	Download
M	ui/gfx/image/image_util.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 11 (0 generated)

Expand Messages | Collapse Messages

sky

Also, updated your description. You're not deprecating, you're getting rid of:) http://codereview.chromium.org/10378009/diff/1/chrome/browser/icon_loader_chromeos.cc File chrome/browser/icon_loader_chromeos.cc (right): ...

8 years, 7 months ago (2012-05-04 16:18:23 UTC) #2

Robert Sesek

Also please at least CC me on any change in ui/gfx/image/. http://codereview.chromium.org/10378009/diff/1/ui/base/resource/resource_bundle.cc File ui/base/resource/resource_bundle.cc (right): ...

8 years, 7 months ago (2012-05-04 20:11:58 UTC) #4

pkotwicz

Scott, does the patch still look good to you given the changes I have made ...

8 years, 7 months ago (2012-05-09 05:13:39 UTC) #6

pkotwicz

Scott, does the patch still look good to you given the changes I have made ...

8 years, 7 months ago (2012-05-09 05:13:50 UTC) #7

sky

http://codereview.chromium.org/10378009/diff/12005/ui/gfx/image/image_unittest_util.h File ui/gfx/image/image_unittest_util.h (right): http://codereview.chromium.org/10378009/diff/12005/ui/gfx/image/image_unittest_util.h#newcode21 ui/gfx/image/image_unittest_util.h:21: typedef const SkBitmap PlatformImage; You sure you want this ...

8 years, 7 months ago (2012-05-09 14:24:03 UTC) #8

pkotwicz

https://chromiumcodereview.appspot.com/10378009/diff/12005/ui/gfx/image/image_unittest_util.h File ui/gfx/image/image_unittest_util.h (right): https://chromiumcodereview.appspot.com/10378009/diff/12005/ui/gfx/image/image_unittest_util.h#newcode38 ui/gfx/image/image_unittest_util.h:38: // Gets the platform representation and returns true if ...

8 years, 7 months ago (2012-05-10 21:56:07 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10378009/16027

8 years, 7 months ago (2012-05-14 00:12:55 UTC) #10

commit-bot: I haz the power

8 years, 7 months ago (2012-05-14 00:13:17 UTC) #11

Presubmit check for 10378009-16027 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

If this change requires manual test instructions to QA team, add
TEST=[instructions].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/profiles

Presubmit checks took 3.6s to calculate.

Expand Messages | Collapse Messages