Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures. (Closed)

Created:
8 years, 7 months ago by Ilya Sherman
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)
Visibility:
Public.

Description

Add additional error logging to investigate Autocomplete Sync failures. BUG=122687 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137617

Patch Set 1 #

Patch Set 2 : Return an enum value instead #

Patch Set 3 : Revert a couple of stray changes #

Total comments: 6

Patch Set 4 : De-nitting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+152 lines, -68 lines) Patch
M chrome/browser/sync/glue/generic_change_processor.cc View 1 2 3 1 chunk +34 lines, -7 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 1 2 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/sync/glue/theme_model_associator.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_autofill_unittest.cc View 1 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_password_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_preference_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 2 3 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_typed_url_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M sync/internal_api/syncapi_unittest.cc View 1 9 chunks +33 lines, -18 lines 0 comments Download
M sync/internal_api/write_node.h View 1 2 3 2 chunks +16 lines, -3 lines 0 comments Download
M sync/internal_api/write_node.cc View 1 2 3 chunks +15 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ilya Sherman
This adds logging for each possible source of errors, though I'm not sure how to ...
8 years, 7 months ago (2012-05-11 00:22:18 UTC) #1
Ilya Sherman
Re-written to generate a unique error for each different type of failure. PTAL.
8 years, 7 months ago (2012-05-17 00:04:52 UTC) #2
tim (not reviewing)
LGTM https://chromiumcodereview.appspot.com/10310113/diff/7001/chrome/browser/sync/glue/generic_change_processor.cc File chrome/browser/sync/glue/generic_change_processor.cc (right): https://chromiumcodereview.appspot.com/10310113/diff/7001/chrome/browser/sync/glue/generic_change_processor.cc#newcode208 chrome/browser/sync/glue/generic_change_processor.cc:208: There are extra newlines before each case. https://chromiumcodereview.appspot.com/10310113/diff/7001/sync/internal_api/write_node.cc ...
8 years, 7 months ago (2012-05-17 00:22:10 UTC) #3
Ilya Sherman
https://chromiumcodereview.appspot.com/10310113/diff/7001/chrome/browser/sync/glue/generic_change_processor.cc File chrome/browser/sync/glue/generic_change_processor.cc (right): https://chromiumcodereview.appspot.com/10310113/diff/7001/chrome/browser/sync/glue/generic_change_processor.cc#newcode208 chrome/browser/sync/glue/generic_change_processor.cc:208: On 2012/05/17 00:22:10, timsteele wrote: > There are extra ...
8 years, 7 months ago (2012-05-17 00:40:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10310113/10002
8 years, 7 months ago (2012-05-17 00:45:04 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-17 02:23:21 UTC) #6
Change committed as 137617

Powered by Google App Engine
This is Rietveld 408576698