chrome/browser/sync/glue/typed_url_model_associator.cc - Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/typed_url_model_associator.cc

Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: De-nitting Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/glue/typed_url_change_processor.cc ('k') | chrome/browser/sync/profile_sync_service_autofill_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/glue/typed_url_model_associator.cc

diff --git a/chrome/browser/sync/glue/typed_url_model_associator.cc b/chrome/browser/sync/glue/typed_url_model_associator.cc

index ad90e63ed38d903729161237383ccf6456983dde..45e9b79cc51115b7096dd790dd3b54f844a39b52 100644

--- a/chrome/browser/sync/glue/typed_url_model_associator.cc

+++ b/chrome/browser/sync/glue/typed_url_model_associator.cc

@@ -273,8 +273,10 @@ SyncError TypedUrlModelAssociator::DoAssociateModels() {

} else {

// Sync has never seen this URL before.

sync_api::WriteNode node(&trans);

- if (!node.InitUniqueByCreation(syncable::TYPED_URLS,

- typed_url_root, tag)) {

+ sync_api::WriteNode::InitUniqueByCreationResult result =

+ node.InitUniqueByCreation(syncable::TYPED_URLS,

+ typed_url_root, tag);

+ if (result != sync_api::WriteNode::INIT_SUCCESS) {

return error_handler_->CreateAndUploadError(

FROM_HERE,

"Failed to create typed_url sync node: " + tag,