chrome/browser/sync/profile_sync_service_session_unittest.cc - Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/profile_sync_service_session_unittest.cc

Issue 10310113: Add additional error logging to investigate Autocomplete Sync failures. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: De-nitting Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync/profile_sync_service_preference_unittest.cc ('k') | chrome/browser/sync/profile_sync_service_typed_url_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/profile_sync_service_session_unittest.cc

diff --git a/chrome/browser/sync/profile_sync_service_session_unittest.cc b/chrome/browser/sync/profile_sync_service_session_unittest.cc

index 87287fb403a9fd7dbe8db337868df7a94ea6dec4..368613c14ee4fefb295cf1795ee8f0d725797e19 100644

--- a/chrome/browser/sync/profile_sync_service_session_unittest.cc

+++ b/chrome/browser/sync/profile_sync_service_session_unittest.cc

@@ -1025,8 +1025,9 @@ TEST_F(ProfileSyncServiceSessionTest, DISABLED_MissingHeaderAndTab) {

sync_api::ReadNode root(&trans);

root.InitByTagLookup(syncable::ModelTypeToRootTag(syncable::SESSIONS));

sync_api::WriteNode extra_header(&trans);

- ASSERT_TRUE(extra_header.InitUniqueByCreation(syncable::SESSIONS,

- root, "new_tag"));

+ sync_api::WriteNode::InitUniqueByCreationResult result =

+ extra_header.InitUniqueByCreation(syncable::SESSIONS, root, "new_tag");

+ ASSERT_EQ(sync_api::WriteNode::INIT_SUCCESS, result);

sync_pb::SessionSpecifics specifics;

specifics.set_session_tag(local_tag);

extra_header.SetSessionSpecifics(specifics);

@@ -1055,8 +1056,10 @@ TEST_F(ProfileSyncServiceSessionTest, DISABLED_MultipleHeaders) {

sync_api::ReadNode root(&trans);

root.InitByTagLookup(syncable::ModelTypeToRootTag(syncable::SESSIONS));

sync_api::WriteNode extra_header(&trans);

- ASSERT_TRUE(extra_header.InitUniqueByCreation(syncable::SESSIONS,

- root, local_tag + "_"));

+ sync_api::WriteNode::InitUniqueByCreationResult result =

+ extra_header.InitUniqueByCreation(syncable::SESSIONS,

+ root, local_tag + "_");

+ ASSERT_EQ(sync_api::WriteNode::INIT_SUCCESS, result);

sync_pb::SessionSpecifics specifics;

specifics.set_session_tag(local_tag);

specifics.mutable_header();

@@ -1086,8 +1089,10 @@ TEST_F(ProfileSyncServiceSessionTest, DISABLED_CorruptedForeign) {

sync_api::ReadNode root(&trans);

root.InitByTagLookup(syncable::ModelTypeToRootTag(syncable::SESSIONS));

sync_api::WriteNode extra_header(&trans);

- ASSERT_TRUE(extra_header.InitUniqueByCreation(syncable::SESSIONS,

- root, foreign_tag));

+ sync_api::WriteNode::InitUniqueByCreationResult result =

+ extra_header.InitUniqueByCreation(syncable::SESSIONS,

+ root, foreign_tag);

+ ASSERT_EQ(sync_api::WriteNode::INIT_SUCCESS, result);

sync_pb::SessionSpecifics specifics;

specifics.set_session_tag(foreign_tag);

extra_header.SetSessionSpecifics(specifics);