Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 10290006: Update gl2.h and gl2ext.h headers from Khronos. (Closed)

Created:
8 years, 7 months ago by nfullagar
Modified:
8 years, 7 months ago
Reviewers:
greggman
CC:
chromium-reviews, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, apatrick_chromium, ihf+watch_chromium.org
Visibility:
Public.

Description

Update gl2.h and gl2ext.h headers from Khronos. These headers make using gl extensions easier. BUG=none TEST=ppb_graphics3d,building of gles book examples Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135074

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1420 lines, -37 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/c/ppb_opengles2.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/lib/gl/gles2/gles2.c View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/lib/gl/include/GLES2/gl2.h View 1 2 3 4 chunks +173 lines, -5 lines 0 comments Download
M ppapi/lib/gl/include/GLES2/gl2ext.h View 29 chunks +1200 lines, -26 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi/nacl.scons View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/native_client/tests/ppapi/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.cc View 3 chunks +34 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/ppapi_browser/ppb_graphics3d/ppapi_ppb_graphics3d.html View 1 chunk +3 lines, -0 lines 0 comments Download
M ppapi/native_client/tests/ppapi_gles_book/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
nfullagar
8 years, 7 months ago (2012-05-02 22:57:13 UTC) #1
greggman
lgtm https://chromiumcodereview.appspot.com/10290006/diff/8001/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc File ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc (right): https://chromiumcodereview.appspot.com/10290006/diff/8001/ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc#newcode172 ppapi/native_client/src/shared/ppapi_proxy/browser_ppp.cc:172: const_cast<char *>(PPP_INSTANCE_INTERFACE_1_0), 80 chars?
8 years, 7 months ago (2012-05-02 23:20:49 UTC) #2
nfullagar
thx. Added John Bauman's suggestion to remove #undef GL_APIENTRY #define GL_APIENTRY from gl2.h GL_APIENTRY will ...
8 years, 7 months ago (2012-05-03 01:15:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nfullagar@google.com/10290006/25002
8 years, 7 months ago (2012-05-03 01:16:10 UTC) #4
commit-bot: I haz the power
Presubmit check for 10290006-25002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-03 01:16:37 UTC) #5
nfullagar
8 years, 7 months ago (2012-05-03 02:02:24 UTC) #6
committed by hand - auto generated files rejected by presubmit checks in CQ.
Committed revision 135074.

Powered by Google App Engine
This is Rietveld 408576698