Issue 10241005: Make win_aura work without ash.

Issue 10241005: Make win_aura work without ash. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 7 months ago

Reviewers:
Elliot Glaysher, sky

CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Make views_examples work in aura without ash. This required a ScreenImpl implementation for windows+aura. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134136

Patch Set 2 : #

Total comments: 3

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+260 lines, -24 lines)			Patch
M	ui/aura/aura.gyp	View		1 chunk	+4 lines, -0 lines	0 comments	Download
A	ui/aura/desktop/desktop_screen.h	View		1 chunk	+23 lines, -0 lines	1 comment	Download
A	ui/aura/desktop/desktop_screen_win.h	View		1 chunk	+35 lines, -0 lines	0 comments	Download
A	ui/aura/desktop/desktop_screen_win.cc	View		1 chunk	+103 lines, -0 lines	2 comments	Download
A	ui/aura/desktop/desktop_screen_x11.cc	View		1 chunk	+17 lines, -0 lines	0 comments	Download
M	ui/aura/root_window_host.h	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	ui/aura/root_window_host_linux.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/aura/root_window_host_linux.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	ui/aura/root_window_host_win.h	View		3 chunks	+7 lines, -0 lines	0 comments	Download
M	ui/aura/root_window_host_win.cc	View		5 chunks	+15 lines, -0 lines	0 comments	Download
M	ui/base/view_prop.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	ui/base/view_prop.cc	View		5 chunks	+5 lines, -5 lines	0 comments	Download
M	ui/base/view_prop_unittest.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	ui/ui.gyp	View	1	3 chunks	+8 lines, -4 lines	0 comments	Download
M	ui/ui_unittests.gypi	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
M	ui/views/examples/content_client/examples_browser_main_parts.cc	View		3 chunks	+6 lines, -7 lines	0 comments	Download
M	ui/views/views.gyp	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

LGTM http://codereview.chromium.org/10241005/diff/3005/ui/aura/desktop/desktop_screen.h File ui/aura/desktop/desktop_screen.h (right): http://codereview.chromium.org/10241005/diff/3005/ui/aura/desktop/desktop_screen.h#newcode18 ui/aura/desktop/desktop_screen.h:18: // a RootWindowHost. Document caller owns returned value. ...

8 years, 8 months ago (2012-04-26 19:15:18 UTC) #3

lgtm

Expand Messages | Collapse Messages