Issue 10204002: Revert 133467 - Convert the last users of DOMView to WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10204002: Revert 133467 - Convert the last users of DOMView to WebView. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)

Modified:
8 years, 8 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 133467 - Convert the last users of DOMView to WebView. Remove DOMView. BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10171006 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133529

Patch Set 1 #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+138 lines, -132 lines)			Patch
M	chrome/browser/chromeos/choose_mobile_network_dialog.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/html_page_screen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/html_page_screen.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/chromeos/login/login_html_dialog.cc	View	1 chunk	+5 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/registration_screen.cc	View	2 chunks	+2 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/login/web_page_view.h	View	3 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/login/web_page_view.cc	View	2 chunks	+5 lines, -8 lines	0 comments	Download
M	chrome/browser/chromeos/sim_dialog_delegate.cc	View	1 chunk	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_cloud.cc	View	2 chunks	+27 lines, -10 lines	0 comments	Download
A +	chrome/browser/ui/views/dom_view.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/views/dom_view.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/views/dom_view_browsertest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/browser/ui/views/html_dialog_view.h	View	6 chunks	+11 lines, -20 lines	0 comments	Download
M	chrome/browser/ui/views/html_dialog_view.cc	View	8 chunks	+36 lines, -43 lines	0 comments	Download
M	chrome/browser/ui/views/html_dialog_view_browsertest.cc	View	4 chunks	+7 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_delegate.cc	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/ui/views/keyboard_overlay_dialog_view.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc	View	7 chunks	+14 lines, -15 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	2 chunks	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages