Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10171006: Convert more users away from DOMView. (Closed)

Created:
8 years, 8 months ago by Ben Goodger (Google)
Modified:
8 years, 8 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Convert the last users of DOMView to WebView. Remove DOMView. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133615

Patch Set 1 : #

Total comments: 5

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -416 lines) Patch
M chrome/browser/chromeos/choose_mobile_network_dialog.cc View 1 2 3 4 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.cc View 1 2 3 4 1 chunk +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/registration_screen.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/registration_screen.cc View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.h View 1 2 3 4 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 1 2 3 4 2 chunks +8 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/sim_dialog_delegate.cc View 1 2 3 4 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 4 2 chunks +6 lines, -39 lines 0 comments Download
D chrome/browser/ui/views/dom_view.h View 1 2 3 4 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/ui/views/dom_view.cc View 1 2 3 4 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/ui/views/dom_view_browsertest.cc View 1 2 3 4 1 chunk +0 lines, -101 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.h View 1 2 3 4 6 chunks +20 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view.cc View 1 2 3 4 8 chunks +44 lines, -36 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 1 2 3 4 4 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_delegate.cc View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/keyboard_overlay_dialog_view.cc View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/virtual_keyboard/virtual_keyboard_manager.cc View 1 2 3 4 7 chunks +15 lines, -14 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 2 chunks +0 lines, -2 lines 0 comments Download
M ui/views/controls/webview/webview.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview.cc View 1 2 3 4 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Ben Goodger (Google)
This is the last of my changes replacing DOMView with views::WebView. Albert: chrome/browser/printing Nikita: login ...
8 years, 8 months ago (2012-04-20 22:27:16 UTC) #1
sky
http://codereview.chromium.org/10171006/diff/7007/chrome/browser/printing/print_dialog_cloud.cc File chrome/browser/printing/print_dialog_cloud.cc (right): http://codereview.chromium.org/10171006/diff/7007/chrome/browser/printing/print_dialog_cloud.cc#newcode693 chrome/browser/printing/print_dialog_cloud.cc:693: #if defined(OS_WIN) Oy, what an ifdef soup. http://codereview.chromium.org/10171006/diff/7007/chrome/browser/ui/views/html_dialog_view.cc File ...
8 years, 8 months ago (2012-04-20 22:59:37 UTC) #2
Albert Bodenhamer
LGTM (I only reviewed print_dialog_cloud.cc) Thanks for cleaning this up. http://codereview.chromium.org/10171006/diff/7007/chrome/browser/printing/print_dialog_cloud.cc File chrome/browser/printing/print_dialog_cloud.cc (right): http://codereview.chromium.org/10171006/diff/7007/chrome/browser/printing/print_dialog_cloud.cc#newcode693 ...
8 years, 8 months ago (2012-04-21 00:19:48 UTC) #3
Ben Goodger (Google)
http://codereview.chromium.org/10171006/diff/7007/chrome/browser/ui/views/html_dialog_view.cc File chrome/browser/ui/views/html_dialog_view.cc (right): http://codereview.chromium.org/10171006/diff/7007/chrome/browser/ui/views/html_dialog_view.cc#newcode306 chrome/browser/ui/views/html_dialog_view.cc:306: static bool initialized = false; On 2012/04/20 22:59:37, sky ...
8 years, 8 months ago (2012-04-21 04:49:28 UTC) #4
sky
http://codereview.chromium.org/10171006/diff/7007/chrome/browser/ui/views/html_dialog_view.cc File chrome/browser/ui/views/html_dialog_view.cc (right): http://codereview.chromium.org/10171006/diff/7007/chrome/browser/ui/views/html_dialog_view.cc#newcode306 chrome/browser/ui/views/html_dialog_view.cc:306: static bool initialized = false; On 2012/04/21 04:49:28, Ben ...
8 years, 8 months ago (2012-04-21 16:13:30 UTC) #5
Ben Goodger (Google)
good point. i guess I didn't study that closely ;) On Sat, Apr 21, 2012 ...
8 years, 8 months ago (2012-04-21 16:51:06 UTC) #6
Nikita (slow)
chromeos/login lgtm
8 years, 8 months ago (2012-04-23 12:12:43 UTC) #7
Ben Goodger (Google)
sky: updated, see html_dialog_view.cc again.
8 years, 8 months ago (2012-04-23 15:50:09 UTC) #8
sky
8 years, 8 months ago (2012-04-23 16:11:31 UTC) #9 
LGTM

Powered by Google App Engine
This is Rietveld 408576698