Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Side by Side Diff: chrome/browser/ui/views/html_dialog_view.h

Issue 10204002: Revert 133467 - Convert the last users of DOMView to WebView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/gtest_prod_util.h" 12 #include "base/gtest_prod_util.h"
13 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
14 #include "chrome/browser/tab_render_watcher.h" 14 #include "chrome/browser/tab_render_watcher.h"
15 #include "chrome/browser/ui/views/dom_view.h"
15 #include "chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h" 16 #include "chrome/browser/ui/webui/html_dialog_tab_contents_delegate.h"
16 #include "chrome/browser/ui/webui/html_dialog_ui.h" 17 #include "chrome/browser/ui/webui/html_dialog_ui.h"
17 #include "ui/gfx/size.h" 18 #include "ui/gfx/size.h"
18 #include "ui/views/view.h"
19 #include "ui/views/widget/widget_delegate.h" 19 #include "ui/views/widget/widget_delegate.h"
20 20
21 class Browser; 21 class Browser;
22 class HtmlDialogController; 22 class HtmlDialogController;
23 class Profile; 23 class Profile;
24 24
25 namespace views {
26 class WebView;
27 }
28
29 //////////////////////////////////////////////////////////////////////////////// 25 ////////////////////////////////////////////////////////////////////////////////
30 // 26 //
31 // HtmlDialogView is a view used to display an HTML dialog to the user. The 27 // HtmlDialogView is a view used to display an HTML dialog to the user. The
32 // content of the dialogs is determined by the delegate 28 // content of the dialogs is determined by the delegate
33 // (HtmlDialogUIDelegate), but is basically a file URL along with a 29 // (HtmlDialogUIDelegate), but is basically a file URL along with a
34 // JSON input string. The HTML is supposed to show a UI to the user and is 30 // JSON input string. The HTML is supposed to show a UI to the user and is
35 // expected to send back a JSON file as a return value. 31 // expected to send back a JSON file as a return value.
36 // 32 //
37 //////////////////////////////////////////////////////////////////////////////// 33 ////////////////////////////////////////////////////////////////////////////////
38 // 34 //
39 // TODO(akalin): Make HtmlDialogView contain an HtmlDialogTabContentsDelegate 35 // TODO(akalin): Make HtmlDialogView contain an HtmlDialogTabContentsDelegate
40 // instead of inheriting from it to avoid violating the "no multiple 36 // instead of inheriting from it to avoid violating the "no multiple
41 // inheritance" rule. 37 // inheritance" rule.
42 // TODO(beng): This class should not depend on Browser or Profile, only
43 // content::BrowserContext.
44 class HtmlDialogView 38 class HtmlDialogView
45 : public views::View, 39 : public DOMView,
46 public HtmlDialogTabContentsDelegate, 40 public HtmlDialogTabContentsDelegate,
47 public HtmlDialogUIDelegate, 41 public HtmlDialogUIDelegate,
48 public views::WidgetDelegate, 42 public views::WidgetDelegate,
49 public TabRenderWatcher::Delegate { 43 public TabRenderWatcher::Delegate {
50 public: 44 public:
51 HtmlDialogView(Profile* profile, 45 HtmlDialogView(Profile* profile,
52 Browser* browser, 46 Browser* browser,
53 HtmlDialogUIDelegate* delegate); 47 HtmlDialogUIDelegate* delegate);
54 virtual ~HtmlDialogView(); 48 virtual ~HtmlDialogView();
55 49
56 // For testing. 50 // Initializes the contents of the dialog (the DOMView and the callbacks).
57 content::WebContents* web_contents(); 51 void InitDialog();
58 52
59 // Overridden from views::View: 53 // Overridden from views::View:
60 virtual gfx::Size GetPreferredSize() OVERRIDE; 54 virtual gfx::Size GetPreferredSize() OVERRIDE;
61 virtual bool AcceleratorPressed(const ui::Accelerator& accelerator) 55 virtual bool AcceleratorPressed(const ui::Accelerator& accelerator)
62 OVERRIDE; 56 OVERRIDE;
63 virtual void ViewHierarchyChanged(bool is_add, 57 virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child)
64 views::View* parent, 58 OVERRIDE;
65 views::View* child) OVERRIDE;
66 59
67 // Overridden from views::WidgetDelegate: 60 // Overridden from views::WidgetDelegate:
68 virtual bool CanResize() const OVERRIDE; 61 virtual bool CanResize() const OVERRIDE;
69 virtual ui::ModalType GetModalType() const OVERRIDE; 62 virtual ui::ModalType GetModalType() const OVERRIDE;
70 virtual string16 GetWindowTitle() const OVERRIDE; 63 virtual string16 GetWindowTitle() const OVERRIDE;
71 virtual std::string GetWindowName() const OVERRIDE; 64 virtual std::string GetWindowName() const OVERRIDE;
72 virtual void WindowClosing() OVERRIDE; 65 virtual void WindowClosing() OVERRIDE;
73 virtual views::View* GetContentsView() OVERRIDE; 66 virtual views::View* GetContentsView() OVERRIDE;
74 virtual views::View* GetInitiallyFocusedView() OVERRIDE; 67 virtual views::View* GetInitiallyFocusedView() OVERRIDE;
75 virtual bool ShouldShowWindowTitle() const OVERRIDE; 68 virtual bool ShouldShowWindowTitle() const OVERRIDE;
(...skipping 26 matching lines...) Expand all
102 content::WebContents* source, 95 content::WebContents* source,
103 const content::OpenURLParams& params) OVERRIDE; 96 const content::OpenURLParams& params) OVERRIDE;
104 virtual void AddNewContents(content::WebContents* source, 97 virtual void AddNewContents(content::WebContents* source,
105 content::WebContents* new_contents, 98 content::WebContents* new_contents,
106 WindowOpenDisposition disposition, 99 WindowOpenDisposition disposition,
107 const gfx::Rect& initial_pos, 100 const gfx::Rect& initial_pos,
108 bool user_gesture) OVERRIDE; 101 bool user_gesture) OVERRIDE;
109 virtual void LoadingStateChanged(content::WebContents* source) OVERRIDE; 102 virtual void LoadingStateChanged(content::WebContents* source) OVERRIDE;
110 103
111 protected: 104 protected:
112 // Overridden from TabRenderWatcher::Delegate: 105 // Register accelerators for this dialog.
106 virtual void RegisterDialogAccelerators();
107
108 // TabRenderWatcher::Delegate implementation.
113 virtual void OnRenderHostCreated(content::RenderViewHost* host) OVERRIDE; 109 virtual void OnRenderHostCreated(content::RenderViewHost* host) OVERRIDE;
114 virtual void OnTabMainFrameLoaded() OVERRIDE; 110 virtual void OnTabMainFrameLoaded() OVERRIDE;
115 virtual void OnTabMainFrameRender() OVERRIDE; 111 virtual void OnTabMainFrameRender() OVERRIDE;
116 112
117 private: 113 private:
118 FRIEND_TEST_ALL_PREFIXES(HtmlDialogBrowserTest, WebContentRendered); 114 FRIEND_TEST_ALL_PREFIXES(HtmlDialogBrowserTest, WebContentRendered);
119 115
120 // Initializes the contents of the dialog. 116 // Whether the view is initialized. That is, dialog acceleartors is registered
121 void InitDialog();
122
123 // Whether the view is initialized. That is, dialog accelerators is registered
124 // and FreezeUpdates property is set to prevent WM from showing the window 117 // and FreezeUpdates property is set to prevent WM from showing the window
125 // until the property is removed. 118 // until the property is removed.
126 bool initialized_; 119 bool initialized_;
127 120
128 // Watches for WebContents rendering. 121 // Watches for WebContents rendering.
129 scoped_ptr<TabRenderWatcher> tab_watcher_; 122 scoped_ptr<TabRenderWatcher> tab_watcher_;
130 123
131 // This view is a delegate to the HTML content since it needs to get notified 124 // This view is a delegate to the HTML content since it needs to get notified
132 // about when the dialog is closing. For all other actions (besides dialog 125 // about when the dialog is closing. For all other actions (besides dialog
133 // closing) we delegate to the creator of this view, which we keep track of 126 // closing) we delegate to the creator of this view, which we keep track of
134 // using this variable. 127 // using this variable.
135 HtmlDialogUIDelegate* delegate_; 128 HtmlDialogUIDelegate* delegate_;
136 129
137 // Controls lifetime of dialog. 130 // Controls lifetime of dialog.
138 scoped_ptr<HtmlDialogController> dialog_controller_; 131 scoped_ptr<HtmlDialogController> dialog_controller_;
139 132
140 views::WebView* web_view_;
141
142 DISALLOW_COPY_AND_ASSIGN(HtmlDialogView); 133 DISALLOW_COPY_AND_ASSIGN(HtmlDialogView);
143 }; 134 };
144 135
145 #endif // CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_ 136 #endif // CHROME_BROWSER_UI_VIEWS_HTML_DIALOG_VIEW_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/dom_view_browsertest.cc ('k') | chrome/browser/ui/views/html_dialog_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698