Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 10142005: Revert 133089 - Implement LauncherIconObserver. (Closed)

Created:
8 years, 8 months ago by dcheng
Modified:
8 years, 8 months ago
Reviewers:
dcheng
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Revert 133089 - Implement LauncherIconObserver. This will be used to listen for changes in the launcher view so that panels can be correctly drawn over the corresponding launcher icon. BUG=124115 TEST=aura_shell_unittests Review URL: https://chromiumcodereview.appspot.com/10116011 TBR=dcheng@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -372 lines) Patch
M ash/ash.gyp View 3 chunks +0 lines, -4 lines 0 comments Download
M ash/launcher/launcher.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/launcher/launcher.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D ash/launcher/launcher_icon_observer.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/launcher/launcher_view.h View 5 chunks +0 lines, -11 lines 0 comments Download
M ash/launcher/launcher_view.cc View 11 chunks +7 lines, -35 lines 0 comments Download
D ash/launcher/launcher_view_unittest.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D ash/test/test_launcher_delegate.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ash/test/test_launcher_delegate.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dcheng
8 years, 8 months ago (2012-04-20 00:45:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698