Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 10116011: Add LauncherIconObserver. (Closed)

Created:
8 years, 8 months ago by dcheng
Modified:
8 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, stevenjb, Dmitry Titov, jennb, jianli, Andrei
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Implement LauncherIconObserver. This will be used to listen for changes in the launcher view so that panels can be correctly drawn over the corresponding launcher icon. BUG=124115 TEST=aura_shell_unittests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133089 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133120

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Total comments: 12

Patch Set 4 : . #

Patch Set 5 : ? #

Total comments: 2

Patch Set 6 : . #

Patch Set 7 : Fix CrOS build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -9 lines) Patch
M ash/ash.gyp View 3 chunks +4 lines, -0 lines 0 comments Download
M ash/launcher/launcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ash/launcher/launcher.cc View 1 chunk +8 lines, -0 lines 0 comments Download
A ash/launcher/launcher_icon_observer.h View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M ash/launcher/launcher_view.h View 5 chunks +11 lines, -0 lines 0 comments Download
M ash/launcher/launcher_view.cc View 11 chunks +35 lines, -7 lines 0 comments Download
A ash/launcher/launcher_view_unittest.cc View 1 2 3 4 5 1 chunk +104 lines, -0 lines 0 comments Download
A ash/test/test_launcher_delegate.h View 1 2 3 4 5 6 1 chunk +69 lines, -0 lines 0 comments Download
A ash/test/test_launcher_delegate.cc View 1 2 3 1 chunk +104 lines, -0 lines 0 comments Download
M ash/test/test_shell_delegate.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
I've updated this patch based on the last comments in the other review thread at ...
8 years, 8 months ago (2012-04-18 23:23:36 UTC) #1
sky
http://codereview.chromium.org/10116011/diff/6001/ash/launcher/launcher_view_unittest.cc File ash/launcher/launcher_view_unittest.cc (right): http://codereview.chromium.org/10116011/diff/6001/ash/launcher/launcher_view_unittest.cc#newcode4 ash/launcher/launcher_view_unittest.cc:4: tests should follow that of non-test cc files and ...
8 years, 8 months ago (2012-04-19 00:05:40 UTC) #2
dcheng
http://codereview.chromium.org/10116011/diff/6001/ash/launcher/launcher_view_unittest.cc File ash/launcher/launcher_view_unittest.cc (right): http://codereview.chromium.org/10116011/diff/6001/ash/launcher/launcher_view_unittest.cc#newcode4 ash/launcher/launcher_view_unittest.cc:4: On 2012/04/19 00:05:40, sky wrote: > tests should follow ...
8 years, 8 months ago (2012-04-19 20:18:15 UTC) #3
sky
LGTM http://codereview.chromium.org/10116011/diff/13001/ash/test/test_launcher_delegate.h File ash/test/test_launcher_delegate.h (right): http://codereview.chromium.org/10116011/diff/13001/ash/test/test_launcher_delegate.h#newcode45 ash/test/test_launcher_delegate.h:45: static TestLauncherDelegate* GetInstance() { return instance_; } nit: ...
8 years, 8 months ago (2012-04-19 21:44:30 UTC) #4
dcheng
8 years, 8 months ago (2012-04-19 21:58:02 UTC) #5
Fixed the build as well. I didn't realize chrome_tests.gypi referenced ash
stuff...

http://codereview.chromium.org/10116011/diff/13001/ash/test/test_launcher_del...
File ash/test/test_launcher_delegate.h (right):

http://codereview.chromium.org/10116011/diff/13001/ash/test/test_launcher_del...
ash/test/test_launcher_delegate.h:45: static TestLauncherDelegate* GetInstance()
{ return instance_; }
On 2012/04/19 21:44:31, sky wrote:
> nit: move this above overriden methods and name it instance().

Done.

Powered by Google App Engine
This is Rietveld 408576698