Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2428)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/chrome_exe.gypi

Issue 10121004: Build Content as a shared library even when using incremental linking. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_installer_util.gypi » ('j') | content/public/common/content_switches.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/chrome_exe.gypi
===================================================================
--- chrome/chrome_exe.gypi (revision 132893)
+++ chrome/chrome_exe.gypi (working copy)
@@ -487,9 +487,6 @@
'app/client_util.cc',
],
}],
- ['OS=="win" and component=="shared_library"', {
- 'defines': ['COMPILE_CONTENT_STATICALLY'],
- }]
Dirk Pranke 2012/04/20 23:29:13 I think this change is bad, it'll cause chrome.exe
],
},
],
« no previous file with comments | « build/common.gypi ('k') | chrome/chrome_installer_util.gypi » ('j') | content/public/common/content_switches.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698