Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3307)

Unified Diff: build/common.gypi

Issue 10121004: Build Content as a shared library even when using incremental linking. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | chrome/chrome_exe.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
===================================================================
--- build/common.gypi (revision 132893)
+++ build/common.gypi (working copy)
@@ -1201,14 +1201,6 @@
['component=="shared_library"', {
'defines': ['COMPONENT_BUILD'],
}],
- ['component=="shared_library" and incremental_chrome_dll==1', {
- # TODO(dpranke): We can't incrementally link chrome when
- # content is being built as a DLL because chrome links in
- # webkit_glue and webkit_glue depends on symbols defined in
- # content. We can remove this when we fix glue.
- # See http://code.google.com/p/chromium/issues/detail?id=98755 .
- 'defines': ['COMPILE_CONTENT_STATICALLY'],
- }],
['toolkit_views==1', {
'defines': ['TOOLKIT_VIEWS=1'],
}],
« no previous file with comments | « no previous file | chrome/chrome_exe.gypi » ('j') | chrome/chrome_exe.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698