Build Content as a shared library even when using incremental linking.

content/public/common/content_switches.h

Index: content/public/common/content_switches.h
===================================================================
--- content/public/common/content_switches.h	(revision 132893)
+++ content/public/common/content_switches.h	(working copy)
@@ -15,7 +15,7 @@
 
 CONTENT_EXPORT extern const char kAllowFileAccessFromFiles[];
 extern const char kAllowSandboxDebugging[];
-extern const char kAllowWebUICompositing[];
+CONTENT_EXPORT extern const char kAllowWebUICompositing[];

[Dirk Pranke, 2012/04/20 23:29:13]

You shouldn't have had to export these symbols as a part of this patch ... this
tells me that we're linking content-switches.cc into chrome.dll directly, and
IIRC we're not supposed to be (it looks like it's getting included via
installer_util, which contains a copy and is now getting linked into
chrome.dll). So I need to dig into how and why that happened and whether it's
okay

(I also don't yet know why incremental linking disabled this such that now your
link failed ...)

[Dirk Pranke, 2012/04/21 00:05:01]

Following up on my own comment, it looks like I'm responsible for this and it's
been broken since the initial content-as-component effort :) I'm not sure how I
didn't notice this before, and haven't yet decided on the best way to fix it,
but it seems like we shouldn't hold up fixing incremental linking as a part of
this. I'm continuing to dig, though ...

 extern const char kAuditHandles[];
 extern const char kAuditAllHandles[];
 CONTENT_EXPORT extern const char kBrowserAssertTest[];
@@ -61,7 +61,7 @@
 CONTENT_EXPORT extern const char kDisablePopupBlocking[];
 extern const char kDisableRemoteFonts[];
 extern const char kDisableRendererAccessibility[];
-extern const char kDisableSSLFalseStart[];
+CONTENT_EXPORT extern const char kDisableSSLFalseStart[];
 extern const char kDisableSeccompSandbox[];
 extern const char kDisableSeccompFilterSandbox[];
 extern const char kDisableSessionStorage[];
@@ -80,20 +80,20 @@
 extern const char kEnableAccessibilityLogging[];
 extern const char kEnableBrowserPlugin[];
 CONTENT_EXPORT extern const char kEnableCompositingForFixedPosition[];
-extern const char kEnableCssRegions[];
+CONTENT_EXPORT extern const char kEnableCssRegions[];
 extern const char kEnableCssShaders[];
 CONTENT_EXPORT extern const char kEnableDeferred2dCanvas[];
 CONTENT_EXPORT extern const char kEnableDeviceMotion[];
 extern const char kEnableFastback[];
 CONTENT_EXPORT extern const char kEnableFixedLayout[];
 CONTENT_EXPORT extern const char kDisableFullScreen[];
-extern const char kEnablePointerLock[];
-extern const char kEnableGamepad[];
+CONTENT_EXPORT extern const char kEnablePointerLock[];
+CONTENT_EXPORT extern const char kEnableGamepad[];
 CONTENT_EXPORT extern const char kEnableLogging[];
-extern const char kEnableMediaSource[];
-extern const char kEnableMediaStream[];
+CONTENT_EXPORT extern const char kEnableMediaSource[];
+CONTENT_EXPORT extern const char kEnableMediaStream[];
 extern const char kEnableMonitorProfile[];
-extern const char kEnableOriginBoundCerts[];
+CONTENT_EXPORT extern const char kEnableOriginBoundCerts[];
 extern const char kEnablePartialSwap[];
 extern const char kEnablePreparsedJsCaching[];
 CONTENT_EXPORT extern const char kEnablePrivilegedWebGLExtensions[];
@@ -101,11 +101,11 @@
 extern const char kEnableSSLCachedInfo[];
 extern const char kEnableSandboxLogging[];
 extern const char kEnableSeccompSandbox[];
-extern const char kEnableShadowDOM[];
-extern const char kEnableStyleScoped[];
+CONTENT_EXPORT extern const char kEnableShadowDOM[];
+CONTENT_EXPORT extern const char kEnableStyleScoped[];
 CONTENT_EXPORT extern const char kEnableSmoothScrolling[];
 CONTENT_EXPORT extern const char kEnableStatsTable[];
-extern const char kEnableStrictSiteIsolation[];
+CONTENT_EXPORT extern const char kEnableStrictSiteIsolation[];
 CONTENT_EXPORT extern const char kEnableThreadedCompositing[];
 CONTENT_EXPORT extern const char kDisableThreadedCompositing[];
 CONTENT_EXPORT extern const char kEnableTcpFastOpen[];
@@ -161,9 +161,9 @@
 extern const char kRendererStartupDialog[];
 // TODO(jam): this doesn't belong in content.
 CONTENT_EXPORT extern const char kServiceProcess[];
-extern const char kShowCompositedLayerBorders[];
+CONTENT_EXPORT extern const char kShowCompositedLayerBorders[];
 extern const char kShowCompositedLayerTree[];
-extern const char kShowFPSCounter[];
+CONTENT_EXPORT extern const char kShowFPSCounter[];
 extern const char kShowPaintRects[];
 CONTENT_EXPORT extern const char kSingleProcess[];
 CONTENT_EXPORT extern const char kSkipGpuDataLoading[];
@@ -195,7 +195,7 @@
 extern const char kUseSystemSSL[];
 #endif
 
-extern const char kEnablePerTilePainting[];
+CONTENT_EXPORT extern const char kEnablePerTilePainting[];
 
 #if defined(USE_AURA)
 CONTENT_EXPORT extern const char kFlingTapSuppressMaxDown[];