Issue 10116017: Remove EPM::all_hosts_

Issue 10116017: Remove EPM::all_hosts_ (Closed)

Created:
8 years, 8 months ago by Aaron Boodman

Modified:
8 years, 7 months ago

Reviewers:

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yoshiki+watch_chromium.org, ajwong+watch_chromium.org, kkania, mihaip+watch_chromium.org, Aaron Boodman, robertshield, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove EPM::all_hosts_. EPM::all_hosts_ is a trap. Everyone thinks that this is where they should look for 'all extension hosts' (reasonably enough, given the name), but it isn't correct at all. BUG=102617

Patch Set 1 #

Patch Set 2 : mostly done #

Patch Set 3 : cleanup #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -110 lines)			Patch
M	chrome/browser/automation/automation_provider_observers.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/automation/automation_util.h	View	1	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/automation/automation_util.cc	View	1	5 chunks	+12 lines, -9 lines	0 comments	Download
M	chrome/browser/automation/testing_automation_provider.cc	View	1 2	4 chunks	+32 lines, -17 lines	1 comment	Download
M	chrome/browser/chrome_content_browser_client.cc	View	1	1 chunk	+4 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.h	View	1 2	4 chunks	+14 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_process_manager.cc	View	1 2	6 chunks	+19 lines, -7 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_context_menu.cc	View	1 2	2 chunks	+4 lines, -18 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.h	View	1	4 chunks	+9 lines, -7 lines	0 comments	Download
M	chrome/browser/task_manager/task_manager_resource_providers.cc	View	1 2	10 chunks	+50 lines, -24 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/testing_automation_provider.cc File chrome/browser/automation/testing_automation_provider.cc (right): http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/testing_automation_provider.cc#newcode2913 chrome/browser/automation/testing_automation_provider.cc:2913: render_view_host->GetDelegate())->did_stop_loading()); Sure would be nice to be able to ...

8 years, 8 months ago (2012-04-19 06:25:40 UTC) #1

benwells

On 2012/04/19 06:25:40, Aaron Boodman wrote: > http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/testing_automation_provider.cc > File chrome/browser/automation/testing_automation_provider.cc (right): > > http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/testing_automation_provider.cc#newcode2913 ...

8 years, 8 months ago (2012-04-19 11:35:40 UTC) #2

benwells

8 years, 8 months ago (2012-04-19 11:36:23 UTC) #3

On 2012/04/19 11:35:40, benwells wrote:
> On 2012/04/19 06:25:40, Aaron Boodman wrote:
> >
>
http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/tes...
> > File chrome/browser/automation/testing_automation_provider.cc (right):
> > 
> >
>
http://codereview.chromium.org/10116017/diff/11/chrome/browser/automation/tes...
> > chrome/browser/automation/testing_automation_provider.cc:2913:
> > render_view_host->GetDelegate())->did_stop_loading());
> > Sure would be nice to be able to get render_view_host->is_loading() here.
> 
> Here is a patch using WebContents instead of RenderViewHost. It gets around
the
> problem of is_loading not being exposed but has other problems.

Oops, here is the patch: https://chromiumcodereview.appspot.com/10113005/

Expand Messages | Collapse Messages