Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1229)

Unified Diff: chrome/browser/extensions/extension_process_manager.h

Issue 10116017: Remove EPM::all_hosts_ (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cleanup Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_process_manager.h
diff --git a/chrome/browser/extensions/extension_process_manager.h b/chrome/browser/extensions/extension_process_manager.h
index c5a936ac6226646f41f2c2db4a5a46c03f732d71..6638a3e4097e769e1a3603c95eacc1d0a9de74bb 100644
--- a/chrome/browser/extensions/extension_process_manager.h
+++ b/chrome/browser/extensions/extension_process_manager.h
@@ -32,9 +32,19 @@ class SiteInstance;
// track of split-mode extensions only.
class ExtensionProcessManager : public content::NotificationObserver {
public:
+ typedef std::set<ExtensionHost*> ExtensionHostSet;
+ typedef ExtensionHostSet::const_iterator const_iterator;
+
static ExtensionProcessManager* Create(Profile* profile);
virtual ~ExtensionProcessManager();
+ const ExtensionHostSet& background_hosts() const {
+ return background_hosts_;
+ }
+
+ typedef std::set<content::RenderViewHost*> ViewSet;
+ const ViewSet GetAllViews() const;
+
// Creates a new ExtensionHost with its associated view, grouping it in the
// appropriate SiteInstance (and therefore process) based on the URL and
// profile.
@@ -86,8 +96,10 @@ class ExtensionProcessManager : public content::NotificationObserver {
std::set<content::RenderViewHost*> GetRenderViewHostsForExtension(
const std::string& extension_id);
- // Returns true if |host| is managed by this process manager.
- bool HasExtensionHost(ExtensionHost* host) const;
+ // Returns the extension associated with the specified RenderViewHost, or
+ // NULL.
+ const Extension* GetExtensionForRenderViewHost(
+ content::RenderViewHost* render_view_host);
// Getter and setter for the lazy background page's keepalive count. This is
// the count of how many outstanding "things" are keeping the page alive.
@@ -109,11 +121,6 @@ class ExtensionProcessManager : public content::NotificationObserver {
void OnNetworkRequestStarted(content::RenderViewHost* render_view_host);
void OnNetworkRequestDone(content::RenderViewHost* render_view_host);
- typedef std::set<ExtensionHost*> ExtensionHostSet;
- typedef ExtensionHostSet::const_iterator const_iterator;
- const_iterator begin() const { return all_hosts_.begin(); }
- const_iterator end() const { return all_hosts_.end(); }
-
protected:
explicit ExtensionProcessManager(Profile* profile);
@@ -134,9 +141,6 @@ class ExtensionProcessManager : public content::NotificationObserver {
content::NotificationRegistrar registrar_;
- // The set of all ExtensionHosts managed by this process manager.
- ExtensionHostSet all_hosts_;
-
// The set of running viewless background extensions.
ExtensionHostSet background_hosts_;

Powered by Google App Engine
This is Rietveld 408576698