Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1460)

Unified Diff: Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/mediastream/RTCVoidRequestImpl.h
diff --git a/Source/modules/mediastream/RTCVoidRequestImpl.h b/Source/modules/mediastream/RTCVoidRequestImpl.h
index de20831d6d7aa9970615e34aee4dc07ef724692b..de093092efbc0caf7adf760f2f77281dadf394c4 100644
--- a/Source/modules/mediastream/RTCVoidRequestImpl.h
+++ b/Source/modules/mediastream/RTCVoidRequestImpl.h
@@ -44,7 +44,12 @@ class VoidCallback;
class RTCVoidRequestImpl final : public RTCVoidRequest, public ActiveDOMObject {
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl);
public:
- static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*);
+ enum RequestType {
+ RequestTypeNone,
+ RequestTypeLocal,
+ RequestTypeRemote
+ };
+ static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*, RequestType);
virtual ~RTCVoidRequestImpl();
// RTCVoidRequest
@@ -57,13 +62,14 @@ public:
DECLARE_VIRTUAL_TRACE();
private:
- RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*);
+ RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCErrorCallback*, RequestType);
void clear();
Member<VoidCallback> m_successCallback;
Member<RTCErrorCallback> m_errorCallback;
Member<RTCPeerConnection> m_requester;
+ RequestType m_requestType;
};
} // namespace blink
« no previous file with comments | « Source/modules/mediastream/RTCSessionDescription.idl ('k') | Source/modules/mediastream/RTCVoidRequestImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698