Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: Source/modules/mediastream/RTCVoidRequestImpl.cpp

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/mediastream/RTCVoidRequestImpl.h ('k') | public/platform/WebRTCSessionDescription.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/mediastream/RTCVoidRequestImpl.cpp
diff --git a/Source/modules/mediastream/RTCVoidRequestImpl.cpp b/Source/modules/mediastream/RTCVoidRequestImpl.cpp
index cfde690ae9e9f1c023e2531a64e4084fc4396ebd..0b467467dfd90bac4501616c384e6d702295d49b 100644
--- a/Source/modules/mediastream/RTCVoidRequestImpl.cpp
+++ b/Source/modules/mediastream/RTCVoidRequestImpl.cpp
@@ -37,18 +37,19 @@
namespace blink {
-RTCVoidRequestImpl* RTCVoidRequestImpl::create(ExecutionContext* context, RTCPeerConnection* requester, VoidCallback* successCallback, RTCErrorCallback* errorCallback)
+RTCVoidRequestImpl* RTCVoidRequestImpl::create(ExecutionContext* context, RTCPeerConnection* requester, VoidCallback* successCallback, RTCErrorCallback* errorCallback, RequestType type)
{
- RTCVoidRequestImpl* request = new RTCVoidRequestImpl(context, requester, successCallback, errorCallback);
+ RTCVoidRequestImpl* request = new RTCVoidRequestImpl(context, requester, successCallback, errorCallback, type);
request->suspendIfNeeded();
return request;
}
-RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnection* requester, VoidCallback* successCallback, RTCErrorCallback* errorCallback)
+RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnection* requester, VoidCallback* successCallback, RTCErrorCallback* errorCallback, RequestType type)
: ActiveDOMObject(context)
, m_successCallback(successCallback)
, m_errorCallback(errorCallback)
, m_requester(requester)
+ , m_requestType(type)
{
ASSERT(m_requester);
}
@@ -60,6 +61,8 @@ RTCVoidRequestImpl::~RTCVoidRequestImpl()
void RTCVoidRequestImpl::requestSucceeded()
{
bool shouldFireCallback = m_requester ? m_requester->shouldFireDefaultCallbacks() : false;
+ m_requester->requestSucceeded(m_requestType);
+
if (shouldFireCallback && m_successCallback)
m_successCallback->handleEvent();
« no previous file with comments | « Source/modules/mediastream/RTCVoidRequestImpl.h ('k') | public/platform/WebRTCSessionDescription.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698