Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Side by Side Diff: Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 1010393002: Fix issue of localDescription and remoteDescription getter. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix test case crash. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 26 matching lines...) Expand all
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class RTCErrorCallback; 40 class RTCErrorCallback;
41 class RTCPeerConnection; 41 class RTCPeerConnection;
42 class VoidCallback; 42 class VoidCallback;
43 43
44 class RTCVoidRequestImpl final : public RTCVoidRequest, public ActiveDOMObject { 44 class RTCVoidRequestImpl final : public RTCVoidRequest, public ActiveDOMObject {
45 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl); 45 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl);
46 public: 46 public:
47 static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, Voi dCallback*, RTCErrorCallback*); 47 enum RequestType {
48 RequestTypeNone,
49 RequestTypeLocal,
50 RequestTypeRemote
51 };
52 static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, Voi dCallback*, RTCErrorCallback*, RequestType);
48 virtual ~RTCVoidRequestImpl(); 53 virtual ~RTCVoidRequestImpl();
49 54
50 // RTCVoidRequest 55 // RTCVoidRequest
51 virtual void requestSucceeded() override; 56 virtual void requestSucceeded() override;
52 virtual void requestFailed(const String& error) override; 57 virtual void requestFailed(const String& error) override;
53 58
54 // ActiveDOMObject 59 // ActiveDOMObject
55 virtual void stop() override; 60 virtual void stop() override;
56 61
57 DECLARE_VIRTUAL_TRACE(); 62 DECLARE_VIRTUAL_TRACE();
58 63
59 private: 64 private:
60 RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTC ErrorCallback*); 65 RTCVoidRequestImpl(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTC ErrorCallback*, RequestType);
61 66
62 void clear(); 67 void clear();
63 68
64 Member<VoidCallback> m_successCallback; 69 Member<VoidCallback> m_successCallback;
65 Member<RTCErrorCallback> m_errorCallback; 70 Member<RTCErrorCallback> m_errorCallback;
66 Member<RTCPeerConnection> m_requester; 71 Member<RTCPeerConnection> m_requester;
72 RequestType m_requestType;
67 }; 73 };
68 74
69 } // namespace blink 75 } // namespace blink
70 76
71 #endif // RTCVoidRequestImpl_h 77 #endif // RTCVoidRequestImpl_h
OLDNEW
« no previous file with comments | « Source/modules/mediastream/RTCSessionDescription.idl ('k') | Source/modules/mediastream/RTCVoidRequestImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698