Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 10084001: Provide empty default implementation of OutputStream::WriteUint32Chunk to make Webkit V8 bindings c… (Closed)

Created:
8 years, 8 months ago by Jakob Kummerow
Modified:
8 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Provide empty default implementation of OutputStream::WriteUint32Chunk to make Webkit V8 bindings compile Committed: https://code.google.com/p/v8/source/detail?r=11311

Patch Set 1 #

Patch Set 2 : added missing return value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M include/v8.h View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
PTAQL.
8 years, 8 months ago (2012-04-13 10:51:10 UTC) #1
Michael Starzinger
LGTM.
8 years, 8 months ago (2012-04-13 10:52:47 UTC) #2
loislo
8 years, 8 months ago (2012-04-13 10:54:39 UTC) #3
On 2012/04/13 10:52:47, Michael Starzinger wrote:
> LGTM.

LGTM

Powered by Google App Engine
This is Rietveld 408576698