Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: include/v8.h

Issue 10084001: Provide empty default implementation of OutputStream::WriteUint32Chunk to make Webkit V8 bindings c… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: added missing return value Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3754 matching lines...) Expand 10 before | Expand all | Expand 10 after
3765 * Writes the next chunk of snapshot data into the stream. Writing 3765 * Writes the next chunk of snapshot data into the stream. Writing
3766 * can be stopped by returning kAbort as function result. EndOfStream 3766 * can be stopped by returning kAbort as function result. EndOfStream
3767 * will not be called in case writing was aborted. 3767 * will not be called in case writing was aborted.
3768 */ 3768 */
3769 virtual WriteResult WriteAsciiChunk(char* data, int size) = 0; 3769 virtual WriteResult WriteAsciiChunk(char* data, int size) = 0;
3770 /** 3770 /**
3771 * Writes the next chunk of heap stats data into the stream. Writing 3771 * Writes the next chunk of heap stats data into the stream. Writing
3772 * can be stopped by returning kAbort as function result. EndOfStream 3772 * can be stopped by returning kAbort as function result. EndOfStream
3773 * will not be called in case writing was aborted. 3773 * will not be called in case writing was aborted.
3774 */ 3774 */
3775 virtual WriteResult WriteUint32Chunk(uint32_t* data, int count) = 0; 3775 // TODO(loislo): Make this pure virtual when WebKit's V8 bindings
3776 // have been updated.
3777 virtual WriteResult WriteUint32Chunk(uint32_t* data, int count) {
3778 return kAbort;
3779 };
3776 }; 3780 };
3777 3781
3778 3782
3779 /** 3783 /**
3780 * An interface for reporting progress and controlling long-running 3784 * An interface for reporting progress and controlling long-running
3781 * activities. 3785 * activities.
3782 */ 3786 */
3783 class V8EXPORT ActivityControl { // NOLINT 3787 class V8EXPORT ActivityControl { // NOLINT
3784 public: 3788 public:
3785 enum ControlOption { 3789 enum ControlOption {
(...skipping 548 matching lines...) Expand 10 before | Expand all | Expand 10 after
4334 4338
4335 4339
4336 } // namespace v8 4340 } // namespace v8
4337 4341
4338 4342
4339 #undef V8EXPORT 4343 #undef V8EXPORT
4340 #undef TYPE_CHECK 4344 #undef TYPE_CHECK
4341 4345
4342 4346
4343 #endif // V8_H_ 4347 #endif // V8_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698