Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: include/v8.h

Issue 10084001: Provide empty default implementation of OutputStream::WriteUint32Chunk to make Webkit V8 bindings c… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: added missing return value Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/v8.h
diff --git a/include/v8.h b/include/v8.h
index f26d24b86a6261438999d46ce6714d456760c55e..0f05230596e19496a7a98515dea6fa918b7a6a31 100644
--- a/include/v8.h
+++ b/include/v8.h
@@ -3772,7 +3772,11 @@ class V8EXPORT OutputStream { // NOLINT
* can be stopped by returning kAbort as function result. EndOfStream
* will not be called in case writing was aborted.
*/
- virtual WriteResult WriteUint32Chunk(uint32_t* data, int count) = 0;
+ // TODO(loislo): Make this pure virtual when WebKit's V8 bindings
+ // have been updated.
+ virtual WriteResult WriteUint32Chunk(uint32_t* data, int count) {
+ return kAbort;
+ };
};
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698