Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 10083064: Revert 132842 - If we are using blocking write, when the renderer stop getting the data without not… (Closed)

Created:
8 years, 8 months ago by Lei Zhang
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), jam, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Revert 132842 - If we are using blocking write, when the renderer stop getting the data without notifying the browser, it will hang the browser. This happens with some plugins which use the sync sockets provided by the Pepper. This patch change CancellableSyncSocket to be non-blocking on sending, so that we don't need to worry the whole browser hangs by one plugin application. Also, we remove the lock in audio_sync_reader.cc since it is not really needed if we don't set the socket_ to NULL when calling Close(). By doing this we allow the user to close the socket while another thread is writing to the socket. BUG=121152 TEST=ipc_tests Review URL: http://codereview.chromium.org/10000004 TBR=xians@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -133 lines) Patch
M base/sync_socket.h View 3 chunks +4 lines, -10 lines 0 comments Download
M base/sync_socket_posix.cc View 3 chunks +2 lines, -23 lines 0 comments Download
M base/sync_socket_win.cc View 3 chunks +11 lines, -27 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/renderer_host/media/audio_sync_reader.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ipc/sync_socket_unittest.cc View 4 chunks +7 lines, -72 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lei Zhang
8 years, 8 months ago (2012-04-18 23:03:41 UTC) #1
Lei Zhang
8 years, 8 months ago (2012-04-18 23:05:22 UTC) #2
You got the email already. This CL caused TSAN failures:

http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28...
http://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Tests%20%2...
(Linux TSAN is still running, but presumably it will also fail)

Powered by Google App Engine
This is Rietveld 408576698