Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed)

Created:
8 years, 8 months ago by Ryan Sleevi
Modified:
8 years, 7 months ago
Reviewers:
sky, Jói, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

RefCounted types should not have public destructors, content/ remaining bits BUG=123295 TEST=none TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136631

Patch Set 1 #

Patch Set 2 : Implementation ordering #

Patch Set 3 : Rebased to Trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+200 lines, -186 lines) Patch
M content/plugin/plugin_channel.h View 1 2 chunks +4 lines, -6 lines 0 comments Download
M content/plugin/plugin_channel.cc View 1 7 chunks +72 lines, -68 lines 0 comments Download
M content/plugin/plugin_thread.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/public/browser/browser_message_filter.h View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/browser/browser_message_filter.cc View 1 4 chunks +48 lines, -48 lines 0 comments Download
M content/public/browser/download_manager.h View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M content/public/browser/indexed_db_context.h View 2 chunks +4 lines, -2 lines 0 comments Download
M content/public/browser/resource_dispatcher_host_login_delegate.h View 1 chunk +4 lines, -2 lines 0 comments Download
M content/public/browser/speech_recognizer.h View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M content/shell/shell_browser_context.cc View 1 2 chunks +9 lines, -6 lines 0 comments Download
M content/shell/shell_login_dialog.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M content/shell/shell_login_dialog.cc View 1 4 chunks +34 lines, -34 lines 0 comments Download
M content/test/mock_download_manager.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M content/test/mock_download_manager.cc View 1 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Ryan Sleevi
joi: PTAL
8 years, 8 months ago (2012-04-13 09:28:33 UTC) #1
Jói
LGTM, thanks!
8 years, 8 months ago (2012-04-13 10:11:43 UTC) #2
Ryan Sleevi
piman, sky: Two more stamps to make commit-bot happy?
8 years, 8 months ago (2012-04-28 01:46:37 UTC) #3
sky
LGTM
8 years, 7 months ago (2012-04-30 13:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069054/4001
8 years, 7 months ago (2012-04-30 14:13:03 UTC) #5
commit-bot: I haz the power
Presubmit check for 10069054-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-04-30 14:13:16 UTC) #6
Ryan Sleevi
piman: ping?
8 years, 7 months ago (2012-05-03 02:28:45 UTC) #7
piman
lgtm
8 years, 7 months ago (2012-05-03 07:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069054/4001
8 years, 7 months ago (2012-05-03 07:12:38 UTC) #9
commit-bot: I haz the power
Presubmit check for 10069054-4001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-03 07:12:56 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069054/4001
8 years, 7 months ago (2012-05-11 17:51:17 UTC) #11
commit-bot: I haz the power
Can't apply patch for file content/public/browser/download_manager.h. While running patch -p1 --forward --force; patching file content/public/browser/download_manager.h ...
8 years, 7 months ago (2012-05-11 17:51:24 UTC) #12
Ryan Sleevi
Rebased to Trunk
8 years, 7 months ago (2012-05-11 17:52:06 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10069054/16002
8 years, 7 months ago (2012-05-11 17:52:19 UTC) #14
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 19:31:00 UTC) #15
Change committed as 136631

Powered by Google App Engine
This is Rietveld 408576698