Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: content/plugin/plugin_thread.cc

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to Trunk Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/plugin/plugin_channel.cc ('k') | content/public/browser/browser_message_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/plugin_thread.cc
diff --git a/content/plugin/plugin_thread.cc b/content/plugin/plugin_thread.cc
index 9b88420cbfe311c88b226c22d80d17d987774c23..75a692e63ee8a700c10409d88df7335c88c21a72 100644
--- a/content/plugin/plugin_thread.cc
+++ b/content/plugin/plugin_thread.cc
@@ -44,9 +44,11 @@ namespace {
class EnsureTerminateMessageFilter : public IPC::ChannelProxy::MessageFilter {
public:
EnsureTerminateMessageFilter() {}
- ~EnsureTerminateMessageFilter() {}
- private:
+ protected:
+ virtual ~EnsureTerminateMessageFilter() {}
+
+ // IPC::ChannelProxy::MessageFilter:
virtual void OnChannelError() {
// How long we wait before forcibly shutting down the process.
const base::TimeDelta kPluginProcessTerminateTimeout =
@@ -60,6 +62,7 @@ class EnsureTerminateMessageFilter : public IPC::ChannelProxy::MessageFilter {
kPluginProcessTerminateTimeout);
}
+ private:
void Terminate() {
base::KillProcess(base::GetCurrentProcessHandle(), 0, false);
}
« no previous file with comments | « content/plugin/plugin_channel.cc ('k') | content/public/browser/browser_message_filter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698