Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: content/plugin/plugin_channel.h

Issue 10069054: RefCounted types should not have public destructors, content/ remaining bits (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebased to Trunk Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/plugin/plugin_channel.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/plugin/plugin_channel.h
diff --git a/content/plugin/plugin_channel.h b/content/plugin/plugin_channel.h
index 7be4d91165ecec51a97c164e2b91594c028c3f70..ed9e215d4a27db5232a9bdd77cb3628d80af4104 100644
--- a/content/plugin/plugin_channel.h
+++ b/content/plugin/plugin_channel.h
@@ -31,10 +31,10 @@ class PluginChannel : public NPChannelBase {
// Send a message to all renderers that the process is going to shutdown.
static void NotifyRenderersOfPendingShutdown();
- virtual ~PluginChannel();
-
+ // IPC::Channel::Listener:
virtual bool Send(IPC::Message* msg) OVERRIDE;
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
+ virtual void OnChannelError() OVERRIDE;
int renderer_id() { return renderer_id_; }
@@ -57,12 +57,10 @@ class PluginChannel : public NPChannelBase {
#endif
protected:
- // IPC::Channel::Listener implementation:
- virtual void OnChannelError() OVERRIDE;
+ virtual ~PluginChannel();
+ // NPChannelBase::
virtual void CleanUp() OVERRIDE;
-
- // Overrides NPChannelBase::Init.
virtual bool Init(base::MessageLoopProxy* ipc_message_loop,
bool create_pipe_now,
base::WaitableEvent* shutdown_event) OVERRIDE;
« no previous file with comments | « no previous file | content/plugin/plugin_channel.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698