Issue 10068006: MIPS: NaNs in the snapshot should be quiet according

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10068006: MIPS: NaNs in the snapshot should be quiet according (Closed)

Created:
8 years, 8 months ago by Erik Corry

Modified:
8 years, 8 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

MIPS: NaNs in the snapshot should be quiet according to the MIPS FPU even when cross-building the snapshot. This is based on code from Daniel Kalmar from http://codereview.chromium.org/9910029/ Committed: https://code.google.com/p/v8/source/detail?r=11283

Patch Set 1 #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -0 lines)			Patch
M	src/assembler.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/mips/assembler-mips.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/mips/assembler-mips.cc	View	1 chunk	+15 lines, -0 lines	1 comment	Download
M	src/serialize.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

8 years, 8 months ago (2012-04-12 09:22:05 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/10068006/diff/1/src/mips/assembler-mip...
File src/mips/assembler-mips.cc (right):

https://chromiumcodereview.appspot.com/10068006/diff/1/src/mips/assembler-mip...
src/mips/assembler-mips.cc:2150: Address value_ptr = object->address() +
HeapNumber::kValueOffset;
please comment why accessors do not work.

Expand Messages | Collapse Messages