Fix IsBaseOf in output_traits.h.

Fix IsBaseOf in output_traits.h.
Previously, it may be used with forward declarations unintentionally and does wrong things silently.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132088

[yzshen1, 2012-04-12 07:29:46]

Hi, Brett.

Would you please take a look? Thanks!

[dmichael (off chromium), 2012-04-12 16:09:35]

lgtm

https://chromiumcodereview.appspot.com/10068004/diff/4/ppapi/cpp/output_traits.h
File ppapi/cpp/output_traits.h (right):

https://chromiumcodereview.appspot.com/10068004/diff/4/ppapi/cpp/output_trait...
ppapi/cpp/output_traits.h:41: typedef char
(*EnsureTypesAreComplete)[sizeof(Base) + sizeof(Derived)];
might as well put this in a private section. (actually, everything but value
could be private)

[yzshen1, 2012-04-12 16:30:46]

http://codereview.chromium.org/10068004/diff/4/ppapi/cpp/output_traits.h
File ppapi/cpp/output_traits.h (right):

http://codereview.chromium.org/10068004/diff/4/ppapi/cpp/output_traits.h#newc...
ppapi/cpp/output_traits.h:41: typedef char
(*EnsureTypesAreComplete)[sizeof(Base) + sizeof(Derived)];
Done. Thanks!

The public section doesn't come first, because most of the private section
(except the line I just added) has to be above the value definition.

On 2012/04/12 16:09:35, dmichael wrote:
> might as well put this in a private section. (actually, everything but value
> could be private)

[brettw, 2012-04-12 18:08:30]

lgtm

[commit-bot: I haz the power, 2012-04-12 18:24:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/10068004/8001

[commit-bot: I haz the power, 2012-04-12 21:40:13]

Try job failure for 10068004-8001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-04-12 21:42:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/10068004/8001

[commit-bot: I haz the power, 2012-04-12 23:21:56]

Change committed as 132088