Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1378)

Unified Diff: ppapi/cpp/dev/audio_input_dev.h

Issue 10068004: Fix IsBaseOf in output_traits.h. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Changes in response to David's suggestion. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/cpp/output_traits.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/cpp/dev/audio_input_dev.h
diff --git a/ppapi/cpp/dev/audio_input_dev.h b/ppapi/cpp/dev/audio_input_dev.h
index 2b2b6bb50f173ef0dcc7189dfde8eb188d6ee2bd..1c80f4db5ee4fd07c15277cec02f865bc823263d 100644
--- a/ppapi/cpp/dev/audio_input_dev.h
+++ b/ppapi/cpp/dev/audio_input_dev.h
@@ -59,11 +59,6 @@ class AudioInput_Dev : public Resource {
/// struct.
const AudioConfig& config() const { return config_; }
- // TODO(yzshen, brettw): If we forward declare DeviceRef_Dev (as opposed to
- // including its .h file), it still compiles. However, it is not recognized as
- // a derived class of Resource and does the wrong thing!
- // This is due to the limitation of IsBaseOf in ppapi/cpp/output_traits.h. We
- // need to figure out a way to overcome this problem.
int32_t EnumerateDevices(
const CompletionCallbackWithOutput<std::vector<DeviceRef_Dev> >&
callback);
« no previous file with comments | « no previous file | ppapi/cpp/output_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698