Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10031044: TabContents -> WebContentsImpl, part 5. (Closed)

Created:
8 years, 8 months ago by Avi (use Gerrit)
Modified:
8 years, 8 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, yusukes+watch_chromium.org, brettw-cc_chromium.org, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, timurrrr+watch_chromium.org, ajwong+watch_chromium.org, pam+watch_chromium.org, James Su, glider+watch_chromium.org, bruening+watch_chromium.org
Visibility:
Public.

Description

TabContents -> WebContentsImpl, part 5. TabContentsViewAura -> WebContentsViewAura TabContentsViewGtk -> WebContentsViewGtk TabContentsViewHelper -> WebContentsViewHelper TabContentsViewWin -> WebContentsViewWin BUG=105875 TEST=no change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131779

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase (fixed) #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+266 lines, -2551 lines) Patch
M chrome/browser/DEPS View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/browser_window_gtk.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_container_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/native_tab_contents_view_win.cc View 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_views.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.h View 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_aura.h View 1 chunk +0 lines, -143 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_aura.cc View 1 1 chunk +0 lines, -599 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_gtk.h View 1 chunk +0 lines, -151 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_gtk.cc View 1 chunk +0 lines, -430 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_helper.h View 1 chunk +0 lines, -104 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_helper.cc View 1 chunk +0 lines, -218 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_win.h View 1 chunk +0 lines, -154 lines 0 comments Download
D content/browser/tab_contents/tab_contents_view_win.cc View 2 1 chunk +0 lines, -485 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_aura.h View 1 4 chunks +9 lines, -9 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_aura.cc View 1 19 chunks +72 lines, -73 lines 3 comments Download
A + content/browser/web_contents/web_contents_view_gtk.h View 5 chunks +12 lines, -12 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_gtk.cc View 16 chunks +45 lines, -45 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_helper.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_helper.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 2 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 2 4 chunks +6 lines, -6 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_win.h View 3 chunks +11 lines, -11 lines 0 comments Download
A + content/browser/web_contents/web_contents_view_win.cc View 2 20 chunks +53 lines, -53 lines 0 comments Download
M content/content_browser.gypi View 2 3 chunks +10 lines, -10 lines 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Avi (use Gerrit)
jam: review erg, ben: fyi for aura, gtk
8 years, 8 months ago (2012-04-11 14:23:04 UTC) #1
Ben Goodger (Google)
Cool.
8 years, 8 months ago (2012-04-11 16:08:53 UTC) #2
jam
lgtm
8 years, 8 months ago (2012-04-11 16:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/avi@chromium.org/10031044/10001
8 years, 8 months ago (2012-04-11 16:11:39 UTC) #4
commit-bot: I haz the power
Presubmit check for 10031044-10001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-11 16:11:55 UTC) #5
Elliot Glaysher
lgtm
8 years, 8 months ago (2012-04-11 17:30:19 UTC) #6
varunjain
https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (left): https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/web_contents/web_contents_view_aura.cc#oldcode429 content/browser/web_contents/web_contents_view_aura.cc:429: provider->set_drag_image_offset(image_offset); Hi Avi... was this intentionally removed?
8 years, 8 months ago (2012-04-23 17:39:45 UTC) #7
Ben Goodger (Google)
https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/web_contents/web_contents_view_aura.cc File content/browser/web_contents/web_contents_view_aura.cc (left): https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/web_contents/web_contents_view_aura.cc#oldcode429 content/browser/web_contents/web_contents_view_aura.cc:429: provider->set_drag_image_offset(image_offset); On 2012/04/23 17:39:45, varunjain wrote: > Hi Avi... ...
8 years, 8 months ago (2012-04-23 17:41:46 UTC) #8
Avi (use Gerrit)
8 years, 8 months ago (2012-04-23 17:54:34 UTC) #9 
https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/we...
File content/browser/web_contents/web_contents_view_aura.cc (left):

https://chromiumcodereview.appspot.com/10031044/diff/10001/content/browser/we...
content/browser/web_contents/web_contents_view_aura.cc:429:
provider->set_drag_image_offset(image_offset);
Indeed. Oops. :(

Powered by Google App Engine
This is Rietveld 408576698