Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(716)

Unified Diff: content/browser/tab_contents/tab_contents_view_helper.h

Issue 10031044: TabContents -> WebContentsImpl, part 5. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase (fixed) Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/tab_contents/tab_contents_view_helper.h
diff --git a/content/browser/tab_contents/tab_contents_view_helper.h b/content/browser/tab_contents/tab_contents_view_helper.h
deleted file mode 100644
index 33fbd3c78e2853f831ec8ecd28f1df7c644bcc25..0000000000000000000000000000000000000000
--- a/content/browser/tab_contents/tab_contents_view_helper.h
+++ /dev/null
@@ -1,104 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_HELPER_H_
-#define CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_HELPER_H_
-#pragma once
-
-#include <map>
-
-#include "base/basictypes.h"
-#include "base/compiler_specific.h"
-#include "content/common/content_export.h"
-#include "content/public/browser/notification_observer.h"
-#include "content/public/browser/notification_registrar.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"
-#include "webkit/glue/window_open_disposition.h"
-
-class WebContentsImpl;
-struct ViewHostMsg_CreateWindow_Params;
-
-namespace content {
-class RenderWidgetHostView;
-class WebContents;
-}
-
-namespace gfx {
-class Rect;
-}
-
-// TODO(avi): Once all the TabContentsViews implementations are in content (I'm
-// looking at you, TabContentsViewViews...) then change the parameters to take
-// WebContentsImpl rather than WebContents.
-
-// Provides helper methods that provide common implementations of some
-// WebContentsView methods.
-class CONTENT_EXPORT TabContentsViewHelper
- : public content::NotificationObserver {
- public:
- TabContentsViewHelper();
- virtual ~TabContentsViewHelper();
-
- // Creates a new window; call |ShowCreatedWindow| below to show it.
- WebContentsImpl* CreateNewWindow(
- content::WebContents* web_contents,
- int route_id,
- const ViewHostMsg_CreateWindow_Params& params);
-
- // Creates a new popup or fullscreen widget; call |ShowCreatedWidget| below to
- // show it. If |is_fullscreen| is true it is a fullscreen widget, if not then
- // a pop-up. |popup_type| is only meaningful for a pop-up.
- content::RenderWidgetHostView* CreateNewWidget(
- content::WebContents* web_contents,
- int route_id,
- bool is_fullscreen,
- WebKit::WebPopupType popup_type);
-
- // Shows a window created with |CreateNewWindow| above.
- WebContentsImpl* ShowCreatedWindow(content::WebContents* web_contents,
- int route_id,
- WindowOpenDisposition disposition,
- const gfx::Rect& initial_pos,
- bool user_gesture);
-
- // Shows a widget created with |CreateNewWidget| above. |initial_pos| is only
- // meaningful for non-fullscreen widgets.
- content::RenderWidgetHostView* ShowCreatedWidget(
- content::WebContents* web_contents,
- int route_id,
- bool is_fullscreen,
- const gfx::Rect& initial_pos);
-
- private:
- // content::NotificationObserver implementation
- virtual void Observe(int type,
- const content::NotificationSource& source,
- const content::NotificationDetails& details) OVERRIDE;
-
- // Finds the new RenderWidgetHost and returns it. Note that this can only be
- // called once as this call also removes it from the internal map.
- content::RenderWidgetHostView* GetCreatedWidget(int route_id);
-
- // Finds the new WebContentsImpl by route_id, initializes it for
- // renderer-initiated creation, and returns it. Note that this can only be
- // called once as this call also removes it from the internal map.
- WebContentsImpl* GetCreatedWindow(int route_id);
-
- // Tracks created WebContentsImpl objects that have not been shown yet. They
- // are identified by the route ID passed to CreateNewWindow.
- typedef std::map<int, WebContentsImpl*> PendingContents;
- PendingContents pending_contents_;
-
- // These maps hold on to the widgets that we created on behalf of the renderer
- // that haven't shown yet.
- typedef std::map<int, content::RenderWidgetHostView*> PendingWidgetViews;
- PendingWidgetViews pending_widget_views_;
-
- // Registers and unregisters us for notifications.
- content::NotificationRegistrar registrar_;
-
- DISALLOW_COPY_AND_ASSIGN(TabContentsViewHelper);
-};
-
-#endif // CONTENT_BROWSER_TAB_CONTENTS_TAB_CONTENTS_VIEW_HELPER_H_

Powered by Google App Engine
This is Rietveld 408576698