Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 10031039: Add ragel validator to SCONS (Closed)

Created:
8 years, 8 months ago by khim
Modified:
8 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add ragel decoder/validator to SCONS BUG=http://code.google.com/p/nativeclient/issues/detail?id=2597 TEST=scons decoder-test validator-test ; ls -al scons-out/*/staging See also: https://chromiumcodereview.appspot.com/9968039/ https://chromiumcodereview.appspot.com/9967015/ Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=8225

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+389 lines, -189 lines) Patch
M PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download
M SConstruct View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/validator_ragel/build.scons View 1 2 3 4 1 chunk +132 lines, -0 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/Makefile View 1 chunk +2 lines, -2 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder.h View 4 chunks +13 lines, -3 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder-test.c View 18 chunks +61 lines, -46 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder-x86_32.rl View 1 chunk +3 lines, -9 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/decoder-x86_64.rl View 1 chunk +4 lines, -9 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/gen-dfa.cc View 30 chunks +95 lines, -62 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator.h View 2 chunks +2 lines, -3 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator-test.c View 6 chunks +36 lines, -20 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator-x86_32.rl View 3 chunks +11 lines, -13 lines 0 comments Download
M src/trusted/validator_ragel/unreviewed/validator-x86_64.rl View 7 chunks +28 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
khim
This time all trybots passed on first try except two clearly misconfigured ones. nacl-lucid_64-newlib-x86_32-pnacl-spec and ...
8 years, 8 months ago (2012-04-11 09:22:50 UTC) #1
pasko-google - do not use
The commit message must be as the original one. More details can be appended, such ...
8 years, 8 months ago (2012-04-11 09:37:59 UTC) #2
khim
PTAL
8 years, 8 months ago (2012-04-11 09:44:08 UTC) #3
pasko-google - do not use
https://chromiumcodereview.appspot.com/10031039/diff/12001/src/trusted/validator_ragel/build.scons File src/trusted/validator_ragel/build.scons (right): https://chromiumcodereview.appspot.com/10031039/diff/12001/src/trusted/validator_ragel/build.scons#newcode22 src/trusted/validator_ragel/build.scons:22: if env.Bit('mac') or env.Bit('asan'): What is happening here? Why ...
8 years, 8 months ago (2012-04-11 09:46:13 UTC) #4
khim
Comment in included in referenced bug.
8 years, 8 months ago (2012-04-11 09:47:34 UTC) #5
pasko-google - do not use
On 2012/04/11 09:47:34, khim wrote: > Comment in included in referenced bug. Then reference the ...
8 years, 8 months ago (2012-04-11 09:48:51 UTC) #6
khim
The reference is there on Line 19.
8 years, 8 months ago (2012-04-11 09:53:34 UTC) #7
pasko-google - do not use
On 2012/04/11 09:53:34, khim wrote: > The reference is there on Line 19. On that ...
8 years, 8 months ago (2012-04-11 09:57:08 UTC) #8
khim
So what do you suggest?
8 years, 8 months ago (2012-04-11 10:00:50 UTC) #9
pasko-google - do not use
On 2012/04/11 10:00:50, khim wrote: > So what do you suggest? Add to the comment ...
8 years, 8 months ago (2012-04-11 10:15:20 UTC) #10
khim
Not sure why XCode comment should go here while MSVC comment is in the bug, ...
8 years, 8 months ago (2012-04-11 10:18:50 UTC) #11
pasko-google - do not use
8 years, 8 months ago (2012-04-11 10:34:21 UTC) #12
lgtm

Powered by Google App Engine
This is Rietveld 408576698