Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 10024054: chromeos: Convert D-Bus client classes' callback arguments to const reference (Closed)

Created:
8 years, 8 months ago by hashimoto
Modified:
8 years, 8 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

chromeos: Convert D-Bus client classes' callback arguments to const reference BUG=chromium-os:28578 TEST=build success Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=131697

Patch Set 1 #

Patch Set 2 : _ #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -167 lines) Patch
M chromeos/dbus/bluetooth_property.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/cashew_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/cashew_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/cros_disks_client.h View 1 chunk +12 lines, -12 lines 0 comments Download
M chromeos/dbus/cros_disks_client.cc View 12 chunks +38 lines, -36 lines 0 comments Download
M chromeos/dbus/cryptohome_client.h View 4 chunks +10 lines, -9 lines 0 comments Download
M chromeos/dbus/cryptohome_client.cc View 20 chunks +25 lines, -24 lines 0 comments Download
M chromeos/dbus/flimflam_client_unittest_base.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M chromeos/dbus/flimflam_client_unittest_base.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/image_burner_client.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/dbus/image_burner_client.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chromeos/dbus/mock_cashew_client.h View 1 chunk +2 lines, -1 line 0 comments Download
M chromeos/dbus/mock_cros_disks_client.h View 1 chunk +19 lines, -12 lines 0 comments Download
M chromeos/dbus/mock_cryptohome_client.h View 1 chunk +10 lines, -9 lines 0 comments Download
M chromeos/dbus/mock_image_burner_client.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_power_manager_client.h View 1 chunk +5 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_session_manager_client.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chromeos/dbus/mock_update_engine_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/dbus/power_manager_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/power_manager_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/session_manager_client.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chromeos/dbus/session_manager_client.cc View 6 chunks +16 lines, -12 lines 0 comments Download
M chromeos/dbus/update_engine_client.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/update_engine_client.cc View 5 chunks +10 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
hashimoto
8 years, 8 months ago (2012-04-10 05:34:53 UTC) #1
satorux1
8 years, 8 months ago (2012-04-10 20:21:16 UTC) #2
LGTM. Thanks!

Powered by Google App Engine
This is Rietveld 408576698