Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: chromeos/dbus/cryptohome_client.h

Issue 10024054: chromeos: Convert D-Bus client classes' callback arguments to const reference (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/cros_disks_client.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/cryptohome_client.h
diff --git a/chromeos/dbus/cryptohome_client.h b/chromeos/dbus/cryptohome_client.h
index df9383238e80d795c13ad49246ffa6602a202676..a152e4463060f4a4b6706a021c59be887edcf102 100644
--- a/chromeos/dbus/cryptohome_client.h
+++ b/chromeos/dbus/cryptohome_client.h
@@ -51,7 +51,8 @@ class CHROMEOS_EXPORT CryptohomeClient {
// |handler| is called when results for AsyncXXX methods are returned.
// Cryptohome service will process the calls in a first-in-first-out manner
// when they are made in parallel.
- virtual void SetAsyncCallStatusHandler(AsyncCallStatusHandler handler) = 0;
+ virtual void SetAsyncCallStatusHandler(
+ const AsyncCallStatusHandler& handler) = 0;
// Resets AsyncCallStatus signal handler.
virtual void ResetAsyncCallStatusHandler() = 0;
@@ -68,19 +69,19 @@ class CHROMEOS_EXPORT CryptohomeClient {
// succeeds.
virtual void AsyncCheckKey(const std::string& username,
const std::string& key,
- AsyncMethodCallback callback) = 0;
+ const AsyncMethodCallback& callback) = 0;
// Calls AsyncMigrateKey method. |callback| is called after the method call
// succeeds.
virtual void AsyncMigrateKey(const std::string& username,
const std::string& from_key,
const std::string& to_key,
- AsyncMethodCallback callback) = 0;
+ const AsyncMethodCallback& callback) = 0;
// Calls AsyncRemove method. |callback| is called after the method call
// succeeds.
virtual void AsyncRemove(const std::string& username,
- AsyncMethodCallback callback) = 0;
+ const AsyncMethodCallback& callback) = 0;
// Calls GetSystemSalt method. This method blocks until the call returns.
// The original content of |salt| is lost.
@@ -91,18 +92,18 @@ class CHROMEOS_EXPORT CryptohomeClient {
virtual void AsyncMount(const std::string& username,
const std::string& key,
const bool create_if_missing,
- AsyncMethodCallback callback) = 0;
+ const AsyncMethodCallback& callback) = 0;
// Calls AsyncMountGuest method. |callback| is called after the method call
// succeeds.
- virtual void AsyncMountGuest(AsyncMethodCallback callback) = 0;
+ virtual void AsyncMountGuest(const AsyncMethodCallback& callback) = 0;
// Calls TpmIsReady method and returns true when the call succeeds.
// This method blocks until the call returns.
virtual bool TpmIsReady(bool* ready) = 0;
// Calls TpmIsEnabled method.
- virtual void TpmIsEnabled(BoolMethodCallback callback) = 0;
+ virtual void TpmIsEnabled(const BoolMethodCallback& callback) = 0;
// Calls TpmIsEnabled method and returns true when the call succeeds.
// This method blocks until the call returns.
@@ -131,11 +132,11 @@ class CHROMEOS_EXPORT CryptohomeClient {
virtual bool TpmClearStoredPassword() = 0;
// Calls Pkcs11IsTpmTokenReady method.
- virtual void Pkcs11IsTpmTokenReady(BoolMethodCallback callback) = 0;
+ virtual void Pkcs11IsTpmTokenReady(const BoolMethodCallback& callback) = 0;
// Calls Pkcs11GetTpmTokenInfo method.
virtual void Pkcs11GetTpmTokenInfo(
- Pkcs11GetTpmTokenInfoCallback callback) = 0;
+ const Pkcs11GetTpmTokenInfoCallback& callback) = 0;
// Calls InstallAttributesGet method and returns true when the call succeeds.
// This method blocks until the call returns.
« no previous file with comments | « chromeos/dbus/cros_disks_client.cc ('k') | chromeos/dbus/cryptohome_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698